Add missing converter: file-name-casing #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
requested changes
Oct 4, 2019
Comment on lines
18
to
22
| const casesMap = new Map(); | ||
| casesMap.set("camel-case", "camelCase"); | ||
| casesMap.set("pascal-case", "pascalCase"); | ||
| casesMap.set("kebab-case", "kebabCase"); | ||
| casesMap.set("snake-case", "snakeCase"); |
There was a problem hiding this comment.
You can make a map with initialized properties in the constructor:
new Map([
["camel-case", "camelCase"],
// ...
]);That being said, I don't think this really needs to be a Map. Only .get is used on it, and always for keys guaranteed to exist. Can you switch it to just a regular object, and initialize it outside of collectArguments (since it's only assigned to and never modified)?
| @@ -0,0 +1,56 @@ | |||
| import { RuleConverter } from "../converter"; | |||
|
|
|||
| const IGNORE_CASE_NOTICE = "ESLint (Unicorn plugin) does not support ignore as case"; | |||
There was a problem hiding this comment.
Suggested change
| const IGNORE_CASE_NOTICE = "ESLint (Unicorn plugin) does not support ignore as case"; | |
| const IGNORE_CASE_NOTICE = "ESLint (Unicorn plugin) does not support the 'ignore' case."; |
...to be a little more clear. Other notices end with periods too.
| casesMap.set("pascal-case", "pascalCase"); | ||
| casesMap.set("kebab-case", "kebabCase"); | ||
| casesMap.set("snake-case", "snakeCase"); | ||
| const foundCases: { [k: string]: any } = {}; |
There was a problem hiding this comment.
Suggested change
| const foundCases: { [k: string]: any } = {}; | |
| const foundCases: { [k: string]: string } = {}; |
...right? Once casesMap is converted to a { [i: string]: string }, this should work more easily in the typings.
JoshuaKGoldberg
added
the
status: waiting for author
* Add notice for changed behavior * Change map to object * Correct notice about the 'ignore' case * Specify map typing
|
Thank you for your feedback! I tried to fix all issues. Let me know if there is anything else. |
JoshuaKGoldberg
approved these changes
Oct 5, 2019
JoshuaKGoldberg
removed
the
status: waiting for author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to issue: #161
PR Checklist
status: accepting prsOverview
Add converter for file-name-casing. Map casings to new rule in the unicorn plugin.