Skip to content

feat: add deprecated/removed rxjs rules #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

rafaelss95
Copy link
Contributor

PR Checklist

Overview

It adds missing converters for deprecated/removed rxjs rules.

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Aug 30, 2021

@rafaelss95 just confirming, is it intentional that these rules are deprecated? I don't see any migration docs on https://github.com/cartant/eslint-plugin-rxjs that would imply that. Is it stated somewhere that they're not going to eventually be re-implemented?

(I don't use rxjs personally, so apologies if this is an obvious question&answer)

@JoshuaKGoldberg JoshuaKGoldberg added the status: needs more information Waiting on the issue author to add additional information label Aug 30, 2021
@rafaelss95
Copy link
Contributor Author

rafaelss95 commented Aug 30, 2021

I've followed the issue cartant/eslint-plugin-rxjs#7 (sorry for not adding this here too as I did in #1195)

@JoshuaKGoldberg JoshuaKGoldberg added status: waiting for reviewer Waiting for a maintainer to review and removed status: needs more information Waiting on the issue author to add additional information labels Aug 30, 2021
@JoshuaKGoldberg
Copy link
Member

Apologies for the delay on these: expect a review by the end of the weekend!

@rafaelss95
Copy link
Contributor Author

take-your-time

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glorious, thanks so mcuh @rafaelss95!

@JoshuaKGoldberg JoshuaKGoldberg merged commit bf32a6e into typescript-eslint:main Sep 20, 2021
@rafaelss95 rafaelss95 deleted the feat/rxjs branch September 21, 2021 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for reviewer Waiting for a maintainer to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants