feat: add deprecated/removed rxjs rules #1200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rafaelss95 just confirming, is it intentional that these rules are deprecated? I don't see any migration docs on https://github.com/cartant/eslint-plugin-rxjs that would imply that. Is it stated somewhere that they're not going to eventually be re-implemented? (I don't use rxjs personally, so apologies if this is an obvious question&answer) |
JoshuaKGoldberg
added
the
status: needs more information
|
I've followed the issue cartant/eslint-plugin-rxjs#7 (sorry for not adding this here too as I did in #1195) |
JoshuaKGoldberg
added
status: waiting for reviewer
|
Apologies for the delay on these: expect a review by the end of the weekend! |
|
|
JoshuaKGoldberg
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
ngrxrules #1194 (comment)status: accepting prsOverview
It adds missing converters for deprecated/removed rxjs rules.