docs(ADVANCED.md): ReactType -> ElementType #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
reviewed
Mar 19, 2019
| @@ -284,10 +284,10 @@ export interface Props { | |||
|
|
|||
| ## `as` props (passing a component to be rendered) | |||
|
|
|||
| `ReactType` is pretty useful to cover most types that can be passed to createElement e.g. | |||
| `ElementType` is pretty useful to cover most types that can be passed to createElement e.g. | |||
There was a problem hiding this comment.
Now that I'm reading this: Shouldn't it cover all types?
There was a problem hiding this comment.
I'd have to double check but it may break on exotic components, although I do think we covered that use case too.
akameco
force-pushed
the
fix/react-element-type
branch
from
c8b42d8 to
6604018
Compare
akameco
force-pushed
the
fix/react-element-type
branch
from
6604018 to
c01f124
Compare
ferdaber
approved these changes
Mar 19, 2019
|
TIL. cheers all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReactTypeis deprecated.see DefinitelyTyped/DefinitelyTyped#33263