Merge pull request Intellicode#220 from AleksandrZhukov/master

Fixed no-raw-text rule for typescript

Author: Intellicode

.gitignore

@@ -27,3 +27,7 @@ build/Release
 node_modules
 
 .idea
+
+# OSX
+#
+.DS_Store

lib/rules/no-raw-text.js

@@ -33,14 +33,16 @@ module.exports = (context) => {
   const skippedElements = options.skip ? options.skip : [];
   const allowedElements = ['Text', 'TSpan', 'StyledText'].concat(skippedElements);
 
+  const hasOnlyLineBreak = value => /^[\r\n\t\f\v]+$/.test(value.replace(/ /g, ''));
+
   const getValidation = node => !allowedElements.includes(elementName(node.parent));
 
   return {
     Literal(node) {
       const parentType = node.parent.type;
       const onlyFor = ['JSXExpressionContainer', 'JSXElement'];
       if (typeof node.value !== 'string' ||
-        /^[\r\n\t\f\v]+$/.test(node.value.replace(/ /g, '')) ||
+        hasOnlyLineBreak(node.value) ||
         !onlyFor.includes(parentType) ||
         (node.parent.parent && node.parent.parent.type === 'JSXAttribute')
       ) return;
@@ -52,6 +54,7 @@ module.exports = (context) => {
     },
 
     JSXText(node) {
+      if (typeof node.value !== 'string' || hasOnlyLineBreak(node.value)) return;
       if (getValidation(node)) {
         report(node);
       }

package.json

@@ -23,6 +23,7 @@
   "homepage": "https://github.com/intellicode/eslint-plugin-react-native",
   "bugs": "https://github.com/intellicode/eslint-plugin-react-native/issues",
   "devDependencies": {
+    "@typescript-eslint/parser": "^1.4.2",
     "babel-eslint": "7.2.3",
     "coveralls": "^3.0.2",
     "eslint": "^5.5.0",
@@ -31,7 +32,8 @@
     "eslint-plugin-jsx-a11y": "^5.1.1",
     "eslint-plugin-react": "^7.3.0",
     "istanbul": "0.4.5",
-    "mocha": "^5.2.0"
+    "mocha": "^5.2.0",
+    "typescript": "^3.3.3333"
   },
   "peerDependencies": {
     "eslint": "^3.17.0 || ^4 || ^5"

tests/lib/rules/no-raw-text.js

@@ -171,7 +171,23 @@ const config = {
   },
 };
 
+const TSConfig = {
+  parser: '@typescript-eslint/parser',
+  parserOptions: {
+    ecmaVersion: 2018,
+    sourceType: 'module',
+    ecmaFeatures: {
+      jsx: true,
+    },
+  },
+};
+
 tests.valid.forEach(t => Object.assign(t, config));
 tests.invalid.forEach(t => Object.assign(t, config));
 
 ruleTester.run('no-raw-text', rule, tests);
+
+tests.valid.forEach(t => Object.assign(t, TSConfig));
+tests.invalid.forEach(t => Object.assign(t, TSConfig));
+
+ruleTester.run('no-raw-text', rule, tests);