Fixed no-raw-text rule for typescript #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed rule for @typescript-eslint/parser - added @typescript-eslint/parser as devDependency - added .DS_Store to .gitignore
|
🎉 |
|
How long is typical for a review and merge of a PR like this? |
|
I don't know, seems need to ask @Intellicode 🙏 |
|
Thanks for your PR, I'm not very familiar with the use case of typescript and eslint, can you explain a little bit about the dev dependencies @AleksandrZhukov? |
|
@Intellicode I'm also not very familiar with typescript, but seems |
|
@AleksandrZhukov alright, seems the other eslint react plugin has it as well, so lets go for it :) |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
May 7, 2019
…ative-community package (#24686) Summary: I need this in my life because version 3.7.0 fixes [this](Intellicode/eslint-plugin-react-native#220) issue. [General][fixed] - Fix an issue with `no-raw-text` rule for TypeScript by updating the eslint-plugin-react-native dependency to 3.7.0 Pull Request resolved: #24686 Differential Revision: D15237597 Pulled By: cpojer fbshipit-source-id: 42ee13997d238025d0c50d154951549392d3abc7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.