Fix 'TableClause' object has no attribute 'dialect_options' #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laserkaplan
approved these changes
Sep 23, 2022
hovaesco
approved these changes
Sep 23, 2022
|
@hashhar: PTAL. It should fix an exception being thrown in Superset. |
ebyhr
reviewed
Sep 26, 2022
mdesmet
force-pushed
the
bug/sql-alchemy-tableclause
branch
from
b1d13a8 to
9a1a57e
Compare
|
@ebyhr : PTAL, test has been added. |
ebyhr
approved these changes
Sep 27, 2022
|
Merged, thanks! |
|
Should there be a PR to update Superset to require a minimum of 0.317.0? |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #237
Release notes
( ) This is not user-visible and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text:
Resolved
'TableClause' object has no attribute 'dialect_options'exception by checking forDialectKWArgsimplementation.