Skip to content

Adding K Nearest Neighbor to ML folder in algorithms with README and tests #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 16, 2020

Conversation

avi09
Copy link
Contributor

@avi09 avi09 commented Dec 15, 2020

Hi Oleksii,

I've created a folder for ML in algorithms and added KNN to it. Added tests in tests folder, and they are running with full code coverage. I have created a README explaining the algorithm. Also I've added KNN to the main README with link. Please do have a look and tell if anything else needs to be done.

Thanks,
Avi

@trekhleb
Copy link
Owner

Hi @avi09,
Good job, thanks for your contribution!

@trekhleb trekhleb changed the base branch from master to merge December 16, 2020 05:44
@trekhleb trekhleb merged commit 871d20d into trekhleb:merge Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants