fixed generic inheritance edge case and added test #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm, just noticed this is a duplicate fix to https://github.com/agronholm/sphinx-autodoc-typehints/pull/60/files. |
|
I'll look at this this Sunday. |
Just curious if you have gotten around to it. I have to disable this plugin for readthedocs right now even though it's super cool since this error kills the build process. Thanks! |
|
Sorry, no. I have a couple PRs to review and merge and I'll do them all today. |
|
I changed the implementation but kept your test. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Type Error that occurs when creating documentation using inherited concrete Generic types as annotations.
Likely closes: https://github.com/agronholm/sphinx-autodoc-typehints/issues/66
Tests have been added for this case. Tests pass on Python 3.6 / OSX