Skip to content

NewType handling #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

NewType handling #45

wants to merge 5 commits into from

Conversation

tibnor
Copy link

@tibnor tibnor commented Jun 14, 2018

Fixes #41

agronholm
agronholm requested changes Jun 17, 2018
View reviewed changes
Copy link
Collaborator

@agronholm agronholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs further discussion.

tests/test_sphinx_autodoc_typehints.py
@@ -2,14 +2,15 @@
import pytest
import sys
import textwrap
from typing import (
Any, AnyStr, Callable, Dict, Generic, Mapping, Optional, Pattern, Tuple, TypeVar, Union, Type)
from typing import Any, AnyStr, Callable, Dict, Generic, \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the old import style.

tests/test_sphinx_autodoc_typehints.py
@@ -69,6 +70,7 @@ class Slotted:
(Callable[[T], T], ':py:data:`~typing.Callable`\\[\\[\\~T], \\~T]'),
(Pattern, ':py:class:`~typing.Pattern`\\[:py:data:`~typing.AnyStr`]'),
(Pattern[str], ':py:class:`~typing.Pattern`\\[:py:class:`str`]'),
(Z, ':py:class:`~typing.NewType.Z`\\[:py:class:`float`]'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is the best way to render these?

@okomestudio okomestudio mentioned this pull request Oct 2, 2018
Closed
@agronholm
Copy link
Collaborator

I merged another PR #66 which resolves this. Thanks for the effort though!

@agronholm agronholm closed this Dec 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agronholm agronholm agronholm requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tibnor @agronholm