Skip to content

[common] ending dot should be added in the toast message #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
winterflame opened this issue Jan 11, 2019 · 1 comment
Closed

[common] ending dot should be added in the toast message #292

winterflame opened this issue Jan 11, 2019 · 1 comment
Assignees
@kinfkong
Labels
tcx_FixAccepted

Comments

@winterflame
Copy link

Reproduction Steps

  1. open the app

  2. click global-string

  3. empty the field, click Save, observe the message

  4. enter some text, save it, observe the message

Expected Result

ending dot should be added in the toast message.

Actual Result

See screenshots.

Screenshots or screencast

If not attached, please check comment section.

Issue Information

Device: Mac Book Pro

OS: macOS High Sierra Version 10.14

Browser: Firefox 64.0.2 (64-bit)
@winterflame
Copy link
Author

no

yes

@kinfkong kinfkong mentioned this issue Jan 14, 2019
Merged
@kinfkong kinfkong self-assigned this Jan 14, 2019
standlove added a commit that referenced this issue Jan 15, 2019
@standlove
Merge pull request #423 from kinfkong/issue-292
5233db4 
Issue #292
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kinfkong kinfkong

Labels
tcx_FixAccepted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kinfkong @standlove @winterflame