Sync Master into develop #1645
Sync Master into develop #1645
Conversation
Standardised skills and minor fixes
Fix bug where copilots can't assign tasks to themselves, even before activation
Update the URL for saving skills
PROD HOTFIX - Handle strings or booleans for `show_data_dashboard` flag
PROD - Support dashboard checkbox for code challenges
Switch how we save the challenge (PS-263)
PROD Release - Work Manager Security Issues (5442)
[RELEASE] PM-413 - Deprecate Connect (5443)
PROD RELEASE - Features and fixes in WM related to deprecating Connect & Submission Review UI apps
[PROD RELEASE] - WorkManager Changes - Connect Decommission
[PROD RELEASE] - release pm1093
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -129,7 +131,7 @@ const UpdateBillingAccount = ({ | |||
| !currentBillingAccount && ( | |||
| <Fragment> | |||
| <span className={styles.error}>No Billing Account set</span> | |||
| {isAdmin && ( | |||
| {(isAdmin || (isManager && isMemberOfActiveProject)) && ( | |||
There was a problem hiding this comment.
The condition (isAdmin || (isManager && isMemberOfActiveProject)) has been added. Ensure that this logic is correct and that it reflects the intended access control. Consider whether this change could inadvertently restrict or broaden access compared to the previous condition isAdmin.
| @@ -153,7 +155,7 @@ const UpdateBillingAccount = ({ | |||
| > | |||
| {isBillingAccountExpired ? 'INACTIVE' : 'ACTIVE'} | |||
| </span>{' '} | |||
| {isAdmin && ( | |||
| {(isAdmin || (isManager && isMemberOfActiveProject)) && ( | |||
There was a problem hiding this comment.
Consider extracting the condition (isAdmin || (isManager && isMemberOfActiveProject)) into a well-named variable to improve readability and maintainability of the code.
| @@ -187,7 +189,9 @@ UpdateBillingAccount.propTypes = { | |||
| isBillingAccountExpired: PropTypes.bool, | |||
| isAdmin: PropTypes.bool, | |||
| projectId: PropTypes.number, | |||
| updateProject: PropTypes.func.isRequired | |||
| updateProject: PropTypes.func.isRequired, | |||
| isMemberOfActiveProject: PropTypes.bool.isRequired, | |||
There was a problem hiding this comment.
The isMemberOfActiveProject prop type should be PropTypes.bool instead of PropTypes.bool.isRequired. The .isRequired should be applied to PropTypes.bool, like this: PropTypes.bool.isRequired.
| updateProject: PropTypes.func.isRequired | ||
| updateProject: PropTypes.func.isRequired, | ||
| isMemberOfActiveProject: PropTypes.bool.isRequired, | ||
| isManager: PropTypes.bool.isRequired |
There was a problem hiding this comment.
The isManager prop type should be PropTypes.bool instead of PropTypes.bool.isRequired. The .isRequired should be applied to PropTypes.bool, like this: PropTypes.bool.isRequired.
No description provided.