feat(PM-972): copilot invitation with email #1638
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -221,6 +221,7 @@ class Users extends Component { | |||
| <UserAddModalContent | |||
| projectId={this.state.projectOption.value} | |||
| addNewProjectMember={this.props.addNewProjectMember} | |||
| onMemberInvited={this.props.addNewProjectInvite} | |||
There was a problem hiding this comment.
Consider renaming the onMemberInvited prop to something more descriptive, such as onInviteMember or handleMemberInvitation, to clearly convey its purpose and maintain consistency with other handler props.
| @@ -55,7 +55,10 @@ const InviteUserModalContent = ({ projectId, onClose, onMemberInvited, projectMe | |||
|
|
|||
| try { | |||
| // api restriction: ONLY "customer" role can be invited via email | |||
| const { success: invitations = [], failed } = await inviteUserToProject(projectId, emailToInvite, PROJECT_ROLES.CUSTOMER) | |||
| const { success: invitations = [], failed } = await inviteUserToProject(projectId, { | |||
There was a problem hiding this comment.
Consider updating the function inviteUserToProject to accept an object as its second parameter, as this change modifies the function call to pass an object instead of separate arguments. Ensure that the function definition and any other calls to it are updated accordingly.
|
|
||
| import styles from './Users.module.scss' | ||
|
|
||
| const theme = { | ||
| container: styles.modalContainer | ||
| } | ||
|
|
||
| const UserAddModalContent = ({ projectId, addNewProjectMember, onClose }) => { | ||
| const UserAddModalContent = ({ projectId, addNewProjectMember, onMemberInvited, onClose }) => { |
There was a problem hiding this comment.
The onMemberInvited prop has been added to the UserAddModalContent component. Ensure that this prop is being used appropriately within the component to handle the copilot invitation flow. If not already implemented, consider adding logic to trigger this callback when a member is successfully invited.
| role: userPermissionToAdd | ||
| }) | ||
| if (failed) { | ||
| const error = get(failed, '0.message', 'Unable to invite user') |
There was a problem hiding this comment.
Consider checking if failed is an array before attempting to access its elements with get(failed, '0.message', 'Unable to invite user'). This will prevent potential runtime errors if failed is not an array.
| setAddUserError(error) | ||
| setIsAdding(false) | ||
| } else { | ||
| onMemberInvited(invitations[0] || {}) |
There was a problem hiding this comment.
Ensure that invitations is an array and has elements before accessing invitations[0]. This will prevent potential runtime errors if invitations is not an array or is empty.
| @@ -59,6 +59,7 @@ export const FILE_PICKER_PROGRESS_INTERVAL = 100 | |||
| export const FILE_PICKER_UPLOAD_RETRY = 2 | |||
| export const FILE_PICKER_UPLOAD_TIMEOUT = 30 * 60 * 1000 // 30 minutes | |||
| export const SPECIFICATION_ATTACHMENTS_FOLDER = 'SPECIFICATION_ATTACHMENTS' | |||
| export const MEMBERS_API_URL = process.env.MEMBERS_API_URL | |||
There was a problem hiding this comment.
Ensure that process.env.MEMBERS_API_URL is defined and has a valid value before using it. Consider adding validation logic to handle cases where the environment variable might be undefined or incorrectly set.
There was a problem hiding this comment.
@hentrymartin can we reuse MEMBERS_API_URL as set via https://github.com/topcoder-platform/work-manager/pull/1638/files#diff-eb618fb9d5e5863df30212207469a147b32305b06fc3606b6a1aaf1fe4f136c4R24?
I want to avoid need to set MEMBERS_API_URL as it can be compiled.
There was a problem hiding this comment.
@kkartunov afaik, we don't have to set the MEMBERS_API_URL, we are loading the env variables into process.env(
work-manager/config/webpack.config.js
Line 493 in 7d0fcd9
| const projectMembers = _.get(project, 'members') | ||
| const invitedMembers = _.get(project, 'invites') | ||
| const invitedUserIds = _.filter(_.map(invitedMembers, 'userId')) |
There was a problem hiding this comment.
Consider checking if invitedUserIds is not empty before calling fetchInviteMembers to avoid unnecessary API calls.
| invitedMembers | ||
| invitedMembers: invitedMembers.map(m => ({ | ||
| ...m, | ||
| email: m.email || invitedUsers[m.userId].email |
There was a problem hiding this comment.
Ensure that invitedUsers[m.userId] is defined before accessing email to prevent potential runtime errors.
| @@ -68,6 +69,19 @@ export async function fetchProjectById (id) { | |||
| return _.get(response, 'data') | |||
| } | |||
|
|
|||
| /** | |||
| * This fetches the user corresponding to the given userIds | |||
| * @param {*} userIds | |||
There was a problem hiding this comment.
Consider specifying the type of userIds in the JSDoc comment. For example, if userIds is expected to be an array of strings, you could write @param {Array<string>} userIds.
| * @param {*} userIds | ||
| */ | ||
| export async function fetchInviteMembers (userIds) { | ||
| const url = `${MEMBERS_API_URL}?${userIds.map(id => `userIds[]=${id}`).join('&')}` |
There was a problem hiding this comment.
Ensure that MEMBERS_API_URL is defined and correctly imported or declared in this file. If it's not, this could lead to runtime errors.
| */ | ||
| export async function fetchInviteMembers (userIds) { | ||
| const url = `${MEMBERS_API_URL}?${userIds.map(id => `userIds[]=${id}`).join('&')}` | ||
| const { data = [] } = await axiosInstance.get(url) |
There was a problem hiding this comment.
Consider adding error handling for the API request. This will help manage scenarios where the request fails or returns an unexpected response.
| emails: [email], | ||
| role: role | ||
| }) | ||
| export async function inviteUserToProject (projectId, params) { |
There was a problem hiding this comment.
The function inviteUserToProject now takes a params object instead of separate email and role parameters. Ensure that the params object is validated to contain the necessary properties (emails and role) before passing it to createProjectMemberInvite. This will prevent potential runtime errors if the params object is malformed.
| @@ -59,6 +59,7 @@ export const FILE_PICKER_PROGRESS_INTERVAL = 100 | |||
| export const FILE_PICKER_UPLOAD_RETRY = 2 | |||
| export const FILE_PICKER_UPLOAD_TIMEOUT = 30 * 60 * 1000 // 30 minutes | |||
| export const SPECIFICATION_ATTACHMENTS_FOLDER = 'SPECIFICATION_ATTACHMENTS' | |||
| export const MEMBERS_API_URL = process.env.MEMBERS_API_URL | |||
There was a problem hiding this comment.
@hentrymartin can we reuse MEMBERS_API_URL as set via https://github.com/topcoder-platform/work-manager/pull/1638/files#diff-eb618fb9d5e5863df30212207469a147b32305b06fc3606b6a1aaf1fe4f136c4R24?
I want to avoid need to set MEMBERS_API_URL as it can be compiled.
What's in this PR?