PM-971 Allow hyphen in url - asset library #1621
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -58,7 +58,7 @@ | |||
| /** | |||
| * regex for url validation | |||
| */ | |||
| const urlRegex = /((https?):\/\/)?(www.)?[a-z0-9]+(\.[a-z]{2,}){1,3}(#?\/?(?:[a-zA-Z0-9#]+))*\/?(\?[a-zA-Z0-9-_]+=[a-zA-Z0-9-%]+&?)?$/ | |||
| const urlRegex = /((https?):\/\/)?(www\.)?[\w-]+(\.[a-z]{2,}){1,3}(#?\/?(?:[a-zA-Z0-9#-]+))*\/?(\?[a-zA-Z0-9-_]+=[a-zA-Z0-9-%]+&?)?$/ | |||
Check failure
Code scanning / CodeQL
Inefficient regular expression High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 month ago
To fix the problem, we need to remove the ambiguity in the regular expression that can cause exponential backtracking. Specifically, we should modify the part [a-zA-Z0-9#-]+ to ensure that the character # is not matched in multiple ways. We can achieve this by using a more specific character class or by restructuring the regular expression to avoid ambiguous matches.
The best way to fix this without changing existing functionality is to replace [a-zA-Z0-9#-]+ with a more precise pattern that avoids ambiguity. For example, we can use [\w-]+ to match word characters and hyphens, and handle the # character separately if needed.
| @@ -60,3 +60,3 @@ | ||
| */ | ||
| const urlRegex = /((https?):\/\/)?(www\.)?[\w-]+(\.[a-z]{2,}){1,3}(#?\/?(?:[a-zA-Z0-9#-]+))*\/?(\?[a-zA-Z0-9-_]+=[a-zA-Z0-9-%]+&?)?$/ | ||
| const urlRegex = /((https?):\/\/)?(www\.)?[\w-]+(\.[a-z]{2,}){1,3}(#?\/?(?:[\w-]+))*\/?(\?[a-zA-Z0-9-_]+=[a-zA-Z0-9-%]+&?)?$/ | ||
|
|
…ression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
What's in this PR?
Changes the regex to allow hyphen in url in the form to add new links for Asset Library