-
Notifications
You must be signed in to change notification settings - Fork 52
feat(PM-810) List and download artifacts in WM #1612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hentrymartin can you deploy this to WM dev env for QA without actually merging it to develop? Can we hold merging it upstream until it passes QA?
What happend with the NPM release?
having "topcoder-react-lib": "github:topcoder-platform/topcoder-react-lib#1.2.18",
in develop is something I want to avoid.
@kkartunov I am not sure why we can't upload to npm registry but justin recommended me to use the github release directly. |
@kkartunov regarding the deployment, yes, I have added this branch name in the circle config and it should deploy to dev env. |
What's in this PR?
Screenshots