Skip to content

feat(PM-810) List and download artifacts in WM #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 6, 2025
Merged

Conversation

hentrymartin
Copy link
Collaborator

What's in this PR?

  • Implemented listing and downloading the artifacts in submissions screen

Screenshots

Screenshot 2025-02-25 at 19 53 53 Screenshot 2025-02-25 at 19 53 42

@kkartunov kkartunov self-requested a review February 27, 2025 15:44
Copy link
Contributor

@kkartunov kkartunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hentrymartin hentrymartin requested a review from kkartunov March 5, 2025 15:47
Copy link
Contributor

@kkartunov kkartunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hentrymartin can you deploy this to WM dev env for QA without actually merging it to develop? Can we hold merging it upstream until it passes QA?

What happend with the NPM release?
having "topcoder-react-lib": "github:topcoder-platform/topcoder-react-lib#1.2.18", in develop is something I want to avoid.

@hentrymartin
Copy link
Collaborator Author

@hentrymartin can you deploy this to WM dev env for QA without actually merging it to develop? Can we hold merging it upstream until it passes QA?

What happend with the NPM release? having "topcoder-react-lib": "github:topcoder-platform/topcoder-react-lib#1.2.18", in develop is something I want to avoid.

@kkartunov I am not sure why we can't upload to npm registry but justin recommended me to use the github release directly.

@hentrymartin
Copy link
Collaborator Author

@hentrymartin can you deploy this to WM dev env for QA without actually merging it to develop? Can we hold merging it upstream until it passes QA?

What happend with the NPM release? having "topcoder-react-lib": "github:topcoder-platform/topcoder-react-lib#1.2.18", in develop is something I want to avoid.

@kkartunov regarding the deployment, yes, I have added this branch name in the circle config and it should deploy to dev env.

@kkartunov kkartunov self-requested a review March 6, 2025 13:45
@hentrymartin hentrymartin merged commit 596b8c4 into develop Mar 6, 2025
3 checks passed
@hentrymartin hentrymartin deleted the pm-810 branch March 6, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants