[$50] No Iterative Reviewer set on F2F

[jmgasper]

Expected behavior

• Launched a F2F
• Selected review type as "internal"
• Selected myself as the copilot

Expected - My account would be set as the Iterative Reviewer

Actual behavior

No reviewer was set, so notifications weren't sent on submission, and the review timeline didn't open.

[drasticdpk]

@vikasrohit ,
Observer Role is showing instead of Iterative Reviewer.

Fro Development and other track is working as expected.

[acshields]

@rootelement @maxceem - Is this a frontend or backend/API update that is needed?

[rootelement]

Work Manager needs to add the selected reviewer as an iterative reviewer resource. I just added myself as one through admin.topcoder.com and it propagated to OR correctly, so this is not an API issue

[vikasrohit]

@rootelement we are already adding the internal reviewer selected by the user as Reviewer resource. Do we need to add the same user as Iterative Reviewer resource as well? If yes, it should be done only for F2Fs or any other challenge type needs this treatment as well?

[vikasrohit]

@maxceem lets add Iterative Reviewer instead of Reviewer role resource for F2Fs of all tracks https://github.com/topcoder-platform/work-manager/blob/develop/src/components/ChallengeEditor/index.js#L968.

[maxceem]

Sum up:

• When we run First2Finish type of challenge

  

• Then when we select Internal Review and choose the reviewer, it should be added using Iterative Reviewer role instead of Reviewer :

  

[maxceem]

@vikasrohit I have some difficulties with testing this.

If I create a challenge type "Challenge" or "F2F" and assigned myself as an internal reviewer. In Online Review I don't have any reviewer role, only Observer.

There are example challenges:

• F2F https://challenges.topcoder-dev.com/projects/16668/challenges/4cd149d5-8444-47e9-86f7-12e50ad0a6ce/view
• Challenge https://challenges.topcoder-dev.com/projects/16668/challenges/ed2c75a5-921e-4c8b-95d0-0a29817d0a59/view

Note, that at the moment user is not shown as assigned reviewer because resources API always return 0 resources due to some issue in Resource API topcoder-platform/resources-api#56. But resource has been created.