issue 2890 fix #39
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| import Modal, { BaseModal } from 'components/Modal'; | ||
| import React from 'react'; | ||
| import ReactDom from 'react-dom'; | ||
| import { | ||
| findInDomByClass, | ||
| renderDom, | ||
| simulate, | ||
| snapshot, | ||
| } from 'utils/jest'; | ||
|
|
||
| beforeAll(() => { | ||
| /* Modal uses ReactJS portals to ensure proper rendering. react-test-renderer, | ||
| * used by utils/jest under the hood, does not support it properly, thus this | ||
| * simple mock for the createPortal(..) function. */ | ||
| ReactDom.createPortal = jest.fn(element => ( | ||
| <div className="MOCK_PORTAL"> | ||
| {element} | ||
| </div> | ||
| )); | ||
| }); | ||
|
|
||
| test('Snapshot match', () => { | ||
| snapshot(<Modal>CONTENT</Modal>); | ||
| }); | ||
|
|
||
| test('onCancel', () => { | ||
| const onCancel = jest.fn(); | ||
| const dom = renderDom(( | ||
| <BaseModal | ||
| onCancel={onCancel} | ||
| theme={{ overlay: 'overlay' }} | ||
| /> | ||
| )); | ||
| const overlay = findInDomByClass(dom, 'overlay'); | ||
| simulate.click(overlay); | ||
| expect(onCancel).toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| test('onWheel', () => { | ||
| const dom = renderDom(( | ||
| <BaseModal | ||
| theme={{ container: 'container' }} | ||
| /> | ||
| )); | ||
| const container = findInDomByClass(dom, 'container'); | ||
| const stopPropagation = jest.fn(); | ||
| simulate.wheel(container, { stopPropagation }); | ||
| expect(stopPropagation).toHaveBeenCalled(); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
|
||
| exports[`Snapshot match 1`] = ` | ||
| <div | ||
| className="MOCK_PORTAL" | ||
| > | ||
| <div | ||
| className="style__container___1SoeQ" | ||
| onWheel={[Function]} | ||
| > | ||
| CONTENT | ||
| </div> | ||
| <button | ||
| className="style__overlay___X12tn" | ||
| onClick={[Function]} | ||
| type="button" | ||
| /> | ||
| </div> | ||
| `; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again, I don't think it's necessary to force a "translation" of {0} to ="0" when you already know it will be 0. tabIndex="0" should be alright