Skip to content

issue 2826 fixed #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

PrakashDurlabhji
Copy link

This PR solves topcoder-platform/community-app#2826.

As above issue depends on PrimaryButton modification at \community-app\src\shared\components\challenge-detail\Header\index.jsx at line 339.

PrimaryButton is imported from topcoder-react-ui-kit.

And Primarybutton in topcoder-react-ui-kit is imported from topcoder-react-utils.

Hence raising PR here.

@PrakashDurlabhji
Copy link
Author

@veshu @codeMinter can anyone please review this?

@luizrrodrigues
Copy link
Collaborator

@PrakashDurlabhji Hey, can you share the your steps used to setup the topcoder-react-utils?

I'm getting error when try deploy this branch, I'm follow these steps:

community-app

  • Checkout qa-accessibility
  • rimraf node_modules
  • npm i

topcoder-react-utils

  • Checkout qa-accessibility
  • npm i
  • npm run build:dev

community-app

  • npm link ../topcoder-react-utils
  • npm run build
  • Error in topcoder-react-utils missing package react-redux-toastr

topcoder-react-utils

  • npm i react-redux-toastr
  • npm run build:dev

community-app

  • npm link ../topcoder-react-utils
  • npm run build
  • Error in topcoder-react-utils missing package slick-carousel

topcoder-react-utils

  • npm i slick-carousel
  • npm run build:dev

community-app

  • npm link ../topcoder-react-utils
  • npm run build
  • Not showing a lot a missing packages:
    • draft-js
    • rc-tooltip
    • react-dates
    • topcoder-react-ui-kit
    • highlight.js

topcoder-react-utils

  • npm i draft-js rc-tooltip react-dates topcoder-react-ui-kit highlight.js
  • npm run build:dev

community-app

  • npm link ../topcoder-react-utils
  • npm run build
  • Now I get this error:

image

@sushilshinde sushilshinde added the On Hold Blocked by another ticket / issue / etc. label Jul 29, 2019
@sushilshinde
Copy link

@PrakashDurlabhji @sexta13 wrong target branch

@PrakashDurlabhji PrakashDurlabhji changed the base branch from develop to qa-accessibility July 29, 2019 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility On Hold Blocked by another ticket / issue / etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants