Skip to content

Code-splitting setup should be updated to be compatible with latest webpack optimizations of code chunks #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
birdofpreyru opened this issue Jun 27, 2018 · 1 comment
Open

Code-splitting setup should be updated to be compatible with latest webpack optimizations of code chunks #20

birdofpreyru opened this issue Jun 27, 2018 · 1 comment
Labels
On Hold Blocked by another ticket / issue / etc. P2 Important. Nice to have improvements and optimizations.

Comments

@birdofpreyru
Copy link
Collaborator

No description provided.

birdofpreyru added a commit that referenced this issue Jul 4, 2018
@birdofpreyru
Enables chunk-splitting optimizations
9ee6bae 
Fix for #20

It seems now that current implementation of AppChunk is compatible with
the optimizations: additional chunks generated by optimizations, seem to
not contain CSS code.
@birdofpreyru
Copy link
Collaborator Author

It turns out that chunk splitting optimization makes quite cumbersome the correct injection of CSS assets during the server-side rendering. Thus, the change above is reverted, and the fix will be postponed (probably, in future versions of Wepback they will add functionality that will make it easy, so we better wait).

@birdofpreyru birdofpreyru added On Hold Blocked by another ticket / issue / etc. P2 Important. Nice to have improvements and optimizations. labels Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
On Hold Blocked by another ticket / issue / etc. P2 Important. Nice to have improvements and optimizations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@birdofpreyru