New settings profile #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Settings profile
Review refactor
|
Can you help merge this PR please? There will be Bug hunt later if we still find some issues or need refactor the code |
|
@dedywahyudi do we need to release update version to npm? |
|
@birdofpreyru Yes, please v0.1.3 |
|
@dedywahyudi sorry, released as v0.2.0, as there much changes from previous v0.1.2 :) |
|
@birdofpreyru Oh no problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@birdofpreyru
This is the updated code refactor for new-settings-profile on topcoder-react-lib
Looking forward your help!
cc @cwdcwd @urwithat @ThomasKranitsas