Skip to content

Fix issue #2387 #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix issue #2387 #71

wants to merge 1 commit into from

Conversation

nauhil
Copy link
Collaborator

@nauhil nauhil commented Jun 11, 2019

@sushilshinde
Copy link
Collaborator

sushilshinde commented Jun 11, 2019

@ThomasKranitsas please review the code, I will make a release if everything is fine

Copy link
Contributor

@ThomasKranitsas ThomasKranitsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sushilshinde @nauhil I feel like we're getting close but still not quite there yet. It's loading all of my challenges when the My challenges bucket is selected but it doesn't load all of them when the All challenges is selected.

Screenshot 2019-06-11 at 18 23 16

@nauhil
Copy link
Collaborator Author

nauhil commented Jun 11, 2019

You faced issue like I faced topcoder-platform/community-app#2387 (comment)

On the All Challenges Page, it just fetches first 50 challenges even though fetches all user challenges. If My challenges are not included in first 50 challenges, it still has this issue.

As I mentioned topcoder-platform/community-app#2387 (comment). Option A cannot make sure fetch all challenges

The root of issue is limit of fetch first 50 challenges on All Challenges Page

@ThomasKranitsas
Copy link
Contributor

@sushilshinde thoughts?

@sushilshinde
Copy link
Collaborator

@sushilshinde thoughts?

Fast is also important but most important is accuracy. Here is my plan on "My Challenges" for now, add few more things to make it acurate

  1. Load whatever number of My challenges that are loade by default but also add View more link/button like other buckets at the bottom that way we are not making user feel that we are cutting off theirs challenges from the results.

  2. Continue to load My Challenges in the background and add one by one not all of them at once so that experience is smooth.

  3. If they click on the My challenges > View more, then it's server call, all the challenges should be loaded, in the same as I mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants