Skip to content

add member stats history/distribution/activeChallenges #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2018
Merged

Conversation

zjuasmn
Copy link
Contributor

@zjuasmn zjuasmn commented Jun 4, 2018

@ThomasKranitsas
Copy link
Contributor

@birdofpreyru can you please merge this? I don't have write access on this repo

@birdofpreyru
Copy link
Collaborator

@ThomasKranitsas Congrats, you have write access to this repo ;)
Just be sure to properly manage version tags, and update CHANGELOG, especially for any breaking changes

@birdofpreyru
Copy link
Collaborator

Ah... well, I guess, write access still does not let you to push to master, thus release updates to npm

@ThomasKranitsas
Copy link
Contributor

Thanks! Any instructions regarding version tags/changelog? I've never done that before :)

@ThomasKranitsas ThomasKranitsas merged commit 89449ba into topcoder-platform:develop Jun 4, 2018
@birdofpreyru
Copy link
Collaborator

  • To bump version in package.json and package-lock.json do one of these:

    $ npm version patch --no-git-tag - to bump the last digit - when you want to get it to npm, and you are sure that changes from the previous version do not introduce any breaking changes;

    $ npm version minor --no-git-tag - to bump the middle digit, and set the last one to zero - when you suspect that there might be breaking changes.

    The version should be bumped in develop branch, then to publish to npm it should merged into master and taged with the version number, prefixed by v, like v0.1.2. CircleCI releases to NPM results of tag builds.

  • In CHANGELOG.md we should keep summary of updates introduced between versions. In case of small updates, it just summaries descriptions of related git commits (in case there many git commits between versions, it is easier to read changelog, than track all commits). But more important is: if version introduces some breaking changes, that requires code updates in other libs / apps depending on the library, then records in changelog should instruct what exactly and how should be updated in such code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants