Skip to content

fix: private challenge message #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

fix: private challenge message #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dec8676
fix: private challenge message
dedywahyudi Sep 22, 2022
ca3660f
fix: 100 max-len
dedywahyudi Sep 22, 2022
d856e72
ci: set test-release
dedywahyudi Sep 23, 2022
2bbd984
fix: PROD-2948
luizrrodrigues Sep 23, 2022
e436ee4
fix: change version to 1000.29.10
dedywahyudi Sep 23, 2022
b7440c8
Merge branch 'reskin-challenge-details' of github.com:topcoder-platfo…
dedywahyudi Sep 23, 2022
56db857
fix: private message only for topgear
dedywahyudi Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- attach_workspace:
at: .
- run: echo "//registry.npmjs.org/:_authToken=$NPM_TOKEN" >> ~/.npmrc
- run: npm publish
- run: npm publish --tag test-release
# dont change anything
workflows:
version: 2
Expand Down
1 change: 1 addition & 0 deletions __tests__/__snapshots__/index.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ Object {
"loadResultsInit": [Function],
"registerDone": [Function],
"registerInit": [Function],
"setCommunityId": [Function],
"toggleCheckpointFeedback": [Function],
"unregisterDone": [Function],
"unregisterInit": [Function],
Expand Down
36 changes: 36 additions & 0 deletions __tests__/reducers/__snapshots__/challenge.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
exports[`Default reducer Creates expected intial state 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": null,
"loadingCheckpoints": false,
"loadingDetailsForChallengeId": "",
Expand All @@ -25,6 +26,7 @@ Object {
exports[`Default reducer Handles CHALLENGE/GET_DETAILS_DONE as expected 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand All @@ -51,6 +53,7 @@ Object {
exports[`Default reducer Handles CHALLENGE/GET_DETAILS_DONE with error as expected 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand All @@ -77,6 +80,7 @@ Object {
exports[`Default reducer Handles CHALLENGE/GET_DETAILS_INIT as expected 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": null,
"fetchChallengeFailure": false,
"loadingCheckpoints": false,
Expand All @@ -100,6 +104,7 @@ Object {
exports[`Default reducer Handles deleteSubmissionDone as expected 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand Down Expand Up @@ -132,6 +137,7 @@ Object {
exports[`Default reducer Handles fetchSubmissionsDone as expected 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand Down Expand Up @@ -166,6 +172,7 @@ Object {
exports[`Default reducer Handles fetchSubmissionsDoneError as expected 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand Down Expand Up @@ -198,6 +205,7 @@ Object {
exports[`Default reducer Handles fetchSubmissionsInit as expected 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand Down Expand Up @@ -229,6 +237,7 @@ exports[`Default reducer Handles getActiveChallengesCountDone as expected 1`] =
Object {
"activeChallengesCount": 5,
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand Down Expand Up @@ -261,6 +270,7 @@ Object {
exports[`Factory with server-side rendering Creates expected intial state 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand Down Expand Up @@ -295,6 +305,7 @@ Object {
exports[`Factory with server-side rendering Handles CHALLENGE/GET_DETAILS_DONE as expected 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand Down Expand Up @@ -329,6 +340,7 @@ Object {
exports[`Factory with server-side rendering Handles CHALLENGE/GET_DETAILS_DONE with error as expected 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand Down Expand Up @@ -363,6 +375,7 @@ Object {
exports[`Factory with server-side rendering Handles CHALLENGE/GET_DETAILS_INIT as expected 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand Down Expand Up @@ -397,6 +410,7 @@ Object {
exports[`Factory with server-side rendering Handles deleteSubmissionDone as expected 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand Down Expand Up @@ -429,6 +443,7 @@ Object {
exports[`Factory with server-side rendering Handles fetchSubmissionsDone as expected 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand Down Expand Up @@ -463,6 +478,7 @@ Object {
exports[`Factory with server-side rendering Handles fetchSubmissionsDoneError as expected 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand Down Expand Up @@ -495,6 +511,7 @@ Object {
exports[`Factory with server-side rendering Handles fetchSubmissionsInit as expected 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand Down Expand Up @@ -526,6 +543,7 @@ exports[`Factory with server-side rendering Handles getActiveChallengesCountDone
Object {
"activeChallengesCount": 5,
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand Down Expand Up @@ -558,6 +576,7 @@ Object {
exports[`Factory without http request Creates expected intial state 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": null,
"loadingCheckpoints": false,
"loadingDetailsForChallengeId": "",
Expand All @@ -580,6 +599,7 @@ Object {
exports[`Factory without http request Handles CHALLENGE/GET_DETAILS_DONE as expected 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand All @@ -606,6 +626,7 @@ Object {
exports[`Factory without http request Handles CHALLENGE/GET_DETAILS_DONE with error as expected 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand All @@ -632,6 +653,7 @@ Object {
exports[`Factory without http request Handles CHALLENGE/GET_DETAILS_INIT as expected 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": null,
"fetchChallengeFailure": false,
"loadingCheckpoints": false,
Expand All @@ -655,6 +677,7 @@ Object {
exports[`Factory without http request Handles deleteSubmissionDone as expected 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand Down Expand Up @@ -687,6 +710,7 @@ Object {
exports[`Factory without http request Handles fetchSubmissionsDone as expected 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand Down Expand Up @@ -721,6 +745,7 @@ Object {
exports[`Factory without http request Handles fetchSubmissionsDoneError as expected 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand Down Expand Up @@ -753,6 +778,7 @@ Object {
exports[`Factory without http request Handles fetchSubmissionsInit as expected 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand Down Expand Up @@ -784,6 +810,7 @@ exports[`Factory without http request Handles getActiveChallengesCountDone as ex
Object {
"activeChallengesCount": 5,
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand Down Expand Up @@ -816,6 +843,7 @@ Object {
exports[`Factory without server-side rendering Creates expected intial state 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": null,
"loadingCheckpoints": false,
"loadingDetailsForChallengeId": "",
Expand All @@ -838,6 +866,7 @@ Object {
exports[`Factory without server-side rendering Handles CHALLENGE/GET_DETAILS_DONE as expected 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand All @@ -864,6 +893,7 @@ Object {
exports[`Factory without server-side rendering Handles CHALLENGE/GET_DETAILS_DONE with error as expected 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand All @@ -890,6 +920,7 @@ Object {
exports[`Factory without server-side rendering Handles CHALLENGE/GET_DETAILS_INIT as expected 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": null,
"fetchChallengeFailure": false,
"loadingCheckpoints": false,
Expand All @@ -913,6 +944,7 @@ Object {
exports[`Factory without server-side rendering Handles deleteSubmissionDone as expected 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand Down Expand Up @@ -945,6 +977,7 @@ Object {
exports[`Factory without server-side rendering Handles fetchSubmissionsDone as expected 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand Down Expand Up @@ -979,6 +1012,7 @@ Object {
exports[`Factory without server-side rendering Handles fetchSubmissionsDoneError as expected 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand Down Expand Up @@ -1011,6 +1045,7 @@ Object {
exports[`Factory without server-side rendering Handles fetchSubmissionsInit as expected 1`] = `
Object {
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand Down Expand Up @@ -1042,6 +1077,7 @@ exports[`Factory without server-side rendering Handles getActiveChallengesCountD
Object {
"activeChallengesCount": 5,
"checkpoints": null,
"communityId": null,
"details": Object {
"id": 123456789,
"tag": "v3-normalized-details",
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"lint:js": "./node_modules/.bin/eslint --ext .js,.jsx .",
"test": "npm run lint && npm run jest"
},
"version": "1.2.10",
"version": "1000.29.11",
"dependencies": {
"auth0-js": "^6.8.4",
"config": "^3.2.0",
Expand Down
11 changes: 11 additions & 0 deletions src/actions/challenge.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,16 @@ function getSubmissionInformationDone(challengeId, submissionId, tokenV3) {
});
}

/**
* @static
* @desc Creates an action that gets communityId
* @param {String} communityId The communityId
* @return {Action}
*/
function setCommunityId(communityId) {
return { communityId: _.toString(communityId) };
}

/**
* @static
* @desc Creates an action that signals beginning of fetching challenge statistics
Expand All @@ -415,6 +425,7 @@ export default createActions({
CHALLENGE: {
DROP_CHECKPOINTS: dropCheckpoints,
DROP_RESULTS: dropResults,
SET_COMMUNITY_ID: setCommunityId,
FETCH_CHECKPOINTS_INIT: fetchCheckpointsInit,
FETCH_CHECKPOINTS_DONE: fetchCheckpointsDone,
GET_DETAILS_INIT: getDetailsInit,
Expand Down
2 changes: 1 addition & 1 deletion src/actions/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { createActions } from 'redux-actions';
export default createActions({
ERRORS: {
CLEAR_ERROR: _.noop,
NEW_ERROR: (title, details) => ({ title, details }),
NEW_ERROR: (title, details, support) => ({ title, details, support }),
CLEAR_ALL_ERROR_ICONS: _.noop,
SET_ERROR_ICON: (id, title, message) => ({ id, title, message }),
CLEAR_ERROR_ICON: id => ({ id }),
Expand Down
Loading