Skip to content

Sync develop with master #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Aug 23, 2022
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
013f693
Merge pull request #278 from topcoder-platform/develop
luizrrodrigues Oct 29, 2020
bd0b4d3
Merge pull request #280 from topcoder-platform/develop
luizrrodrigues Nov 5, 2020
b66d987
Merge pull request #283 from topcoder-platform/develop
luizrrodrigues Nov 10, 2020
cb4bee8
Merge pull request #286 from topcoder-platform/develop
luizrrodrigues Nov 24, 2020
c0d9f53
Merge pull request #290 from topcoder-platform/develop
luizrrodrigues Dec 15, 2020
72119e8
Merge pull request #291 from topcoder-platform/develop
luizrrodrigues Dec 15, 2020
1f0a579
Merge pull request #293 from topcoder-platform/develop
luizrrodrigues Dec 22, 2020
e91421a
Merge pull request #295 from topcoder-platform/develop
luizrrodrigues Jan 26, 2021
2f70b94
Merge pull request #304 from topcoder-platform/develop
luizrrodrigues Mar 1, 2021
9e8cf86
Merge pull request #311 from topcoder-platform/develop
luizrrodrigues May 13, 2021
db9b9a9
Merge pull request #314 from topcoder-platform/develop
luizrrodrigues Aug 20, 2021
beeb40c
Merge pull request #317 from topcoder-platform/develop
luizrrodrigues Oct 7, 2021
3891c38
Merge pull request #321 from topcoder-platform/develop
luizrrodrigues Dec 7, 2021
713e875
Merge pull request #323 from topcoder-platform/develop
rakibansary Dec 10, 2021
aaa7e02
Merge pull request #326 from topcoder-platform/develop
luizrrodrigues Dec 13, 2021
03c1c3c
Merge pull request #332 from topcoder-platform/develop
luizrrodrigues Jan 10, 2022
cb62802
Merge pull request #338 from topcoder-platform/develop
luizrrodrigues Apr 28, 2022
ae727a8
Merge pull request #344 from topcoder-platform/develop
luizrrodrigues Jul 20, 2022
a406dfb
Merge pull request #348 from topcoder-platform/develop
luizrrodrigues Aug 5, 2022
7f36fd0
fix: support old mm challenge, get challenge by roundId
yoution Aug 16, 2022
20daf8d
Merge pull request #351 from topcoder-platform/develop
luizrrodrigues Aug 17, 2022
6f86f31
Merge pull request #350 from yoution/master
jpeg22 Aug 18, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/reducers/challenge.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,18 @@ function onGetDetailsDone(state, action) {
// condition based on ROUTE used for Review Opportunities, change if needed
const challengeId = state.loadingDetailsForChallengeId;
let compareChallenge = details.id;
// to be compatible with old mm challenge, we should get legacyId from roundId firstly,
// like roundId '19038' to legacyId '30233148'
let isOldMmChallenge = false;
if (challengeId.length >= 5 && challengeId.length <= 8) {
compareChallenge = details.legacyId;

if (challengeId !== _.toString(compareChallenge)) {
isOldMmChallenge = true;
}
}

if (_.toString(compareChallenge) !== challengeId) {
if (!isOldMmChallenge && _.toString(compareChallenge) !== challengeId) {
return state;
}

Expand Down