Skip to content

Fix code quality issues from V4 changes #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 29, 2019
Merged

Fix code quality issues from V4 changes #33

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b5e045b
Fix code quality issues from V4 changes
ThomasKranitsas Dec 14, 2018
dd92d26
updating gitignore for dist folder - for testing
sushilshinde Dec 17, 2018
43b2ba6
updating gitignore for dist folder - for testing
sushilshinde Dec 17, 2018
26fd3db
updating gitignore for dist folder - for testing
sushilshinde Dec 17, 2018
3467063
pushing build files
sushilshinde Jan 25, 2019
5e098b5
Resolve conflicts
ThomasKranitsas Jan 29, 2019
f271382
Resolve conflicts
ThomasKranitsas Jan 29, 2019
7f3b805
Fix tests
ThomasKranitsas Jan 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 1 addition & 37 deletions .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,39 +1,3 @@
{
"extends": "./node_modules/topcoder-react-utils/config/eslint/default.json",
"rules": {
"jsx-a11y/label-has-for": [
2,
{
"components": [
"Label"
],
"required": {
"some": [
"nesting",
"id"
]
},
"allowChildren": false
}
],
"jsx-a11y/label-has-associated-control": [
2,
{
"labelComponents": [
"CustomLabel"
],
"labelAttributes": [
"inputLabel"
],
"controlComponents": [
"CustomInput"
],
"depth": 3
}
],
"no-unused-vars": 0,
"no-undef": 0,
"react/jsx-no-undef": 0,
"react/require-default-props": 0
}
"extends": "./node_modules/topcoder-react-utils/config/eslint/default.json"
}
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
__coverage__
.build-info
.sass-cache
dist
#dist
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sushilshinde make sure to revert this line before merging ;)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

node_modules
_auto_doc_
.vscode
Expand Down
4 changes: 2 additions & 2 deletions __tests__/__snapshots__/index.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,8 +309,8 @@ Object {
"Iterative Review": "Iterative Review",
"Spec Review": "Specification Review",
},
"getApiResponsePayloadV3": [Function],
"getApiResponsePayloadV4": [Function],
"getApiResponsePayload": [Function],
"getLookerApiResponsePayload": [Function],
},
"time": Object {
"default": undefined,
Expand Down
1,421 changes: 1,421 additions & 0 deletions dist/dev/index.js
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 6 additions & 0 deletions dist/prod/index.js
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions docs/tc.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,18 @@ Collection of small Topcoder-related functions.

* [tc](#module_tc)
* [.REVIEW_OPPORTUNITY_TYPES](#module_tc.REVIEW_OPPORTUNITY_TYPES)
* [.getApiResponsePayloadV3(res)](#module_tc.getApiResponsePayloadV3) ⇒ <code>Promise</code>
* [.getApiResponsePayload(res)](#module_tc.getApiResponsePayload) ⇒ <code>Promise</code>

<a name="module_tc.REVIEW_OPPORTUNITY_TYPES"></a>

### tc.REVIEW_OPPORTUNITY_TYPES
Review Opportunity types

**Kind**: static constant of [<code>tc</code>](#module_tc)
<a name="module_tc.getApiResponsePayloadV3"></a>
<a name="module_tc.getApiResponsePayload"></a>

### tc.getApiResponsePayloadV3(res) ⇒ <code>Promise</code>
Gets payload from a standard success response from TC API v3; or throws
### tc.getApiResponsePayload(res) ⇒ <code>Promise</code>
Gets payload from a standard success response from TC API; or throws
an error in case of a failure response.

**Kind**: static method of [<code>tc</code>](#module_tc)
Expand Down
Loading