Skip to content

Release 2020-10-09 #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Oct 13, 2020
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
d7e336e
Refactor challenge list
LieutenantRoger Aug 24, 2020
4380099
Fix test issues in lib
LieutenantRoger Aug 30, 2020
86571d7
restore the old filterByType operation
LieutenantRoger Aug 31, 2020
f279356
change groups param
LieutenantRoger Sep 12, 2020
d89ff66
fix: for #4594
luizrrodrigues Sep 21, 2020
6ab57cc
fix challenge detail screen
LieutenantRoger Sep 26, 2020
46c80e6
Merge pull request #259 from topcoder-platform/feature-refactor-chall…
luizrrodrigues Oct 1, 2020
3deb718
fix: for issue #4965
luizrrodrigues Oct 1, 2020
5dc9187
fix: for issue #5036
narekcat Oct 3, 2020
aaef421
Merge branch 'listing-develop-sync' into feature-refactor-challengelist
luizrrodrigues Oct 4, 2020
770c6b4
Merge pull request #266 from topcoder-platform/feature-refactor-chall…
luizrrodrigues Oct 4, 2020
d7c16af
Challengelist sync missing COMPETITION_TRACKS rename
luizrrodrigues Oct 5, 2020
534fb7c
fix: update track abbreviations
cagdas001 Oct 5, 2020
aa5cfd1
Merge pull request #267 from cagdas001/fix-5045
luizrrodrigues Oct 5, 2020
79acf3d
fix: for issue #5045
luizrrodrigues Oct 5, 2020
88f86f2
ci: added dist tag
luizrrodrigues Oct 5, 2020
33aa9bf
Merge pull request #265 from narekcat/issue-5036
luizrrodrigues Oct 7, 2020
732c9e0
fix: for issue #5036
luizrrodrigues Oct 7, 2020
fb80993
Implement TCO filter to Challenge Listing page
luizrrodrigues Oct 8, 2020
0c5827b
Merge pull request #270 from topcoder-platform/issue-5056
luizrrodrigues Oct 9, 2020
de74fea
fix: for issue #5056
luizrrodrigues Oct 9, 2020
b665be9
Merge pull request #271 from topcoder-platform/listing-develop-sync
luizrrodrigues Oct 9, 2020
7c653ab
Smoke Testing 2020-10-09
luizrrodrigues Oct 9, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test issues in lib
  • Loading branch information
LieutenantRoger committed Aug 30, 2020
commit 43800997dcad2b14ba6e22f78447cdec4d11d609
7 changes: 4 additions & 3 deletions __tests__/__snapshots__/index.js.snap
Original file line number Diff line number Diff line change
@@ -303,6 +303,7 @@ Object {
"SUBMISSION_END_DATE": "submissionEndDate",
},
"default": undefined,
"getFilterUrl": [Function],
"getService": [Function],
"normalizeChallenge": [Function],
},
@@ -372,9 +373,9 @@ Object {
},
"tc": Object {
"COMPETITION_TRACKS": Object {
"DATA_SCIENCE": "Data Science",
"DESIGN": "Design",
"DEVELOP": "Development",
"DES": "Design",
"DEV": "Development",
"DS": "Data Science",
"QA": "Quality Assurance",
},
"REVIEW_OPPORTUNITY_TYPES": Object {
8 changes: 4 additions & 4 deletions src/services/challenges.js
Original file line number Diff line number Diff line change
@@ -23,14 +23,14 @@ export function getFilterUrl(backendFilter, frontFilter) {
delete ff.types;
delete ff.communityId;

console.log(ff);
// console.log(ff);

let urlFilter = qs.stringify(_.reduce(ff, (result, value, key) => {
// eslint-disable-next-line no-param-reassign
if (value) result[key] = value;
return result;
}, {}));
console.log(urlFilter);
// console.log(urlFilter);

const ftags = _.map(tags, val => `tags[]=${val}`).join('&');
const ftracks = _.map(_.reduce(tracks, (result, value, key) => {
@@ -165,10 +165,10 @@ class ChallengesService {
endpoint,
filter,
) => {
console.log(filter);
// console.log(filter);
const query = getFilterUrl(filter.backendFilter, filter.frontFilter);
const url = `${endpoint}?${query}`;
console.log(url);
// console.log(url);
const res = await this.private.apiV5.get(url).then(checkErrorV5);
return {
challenges: res.result || [],
4 changes: 2 additions & 2 deletions src/utils/challenge/filter.js
Original file line number Diff line number Diff line change
@@ -238,7 +238,7 @@ export function getFilterFunction(state) {
* @param {Object} state
* @return {Function}
*/
export function getReviewOpportunitiesFilterFunction(state, validTypes) {
export function getReviewOpportunitiesFilterFunction(state) {
return (opp) => {
const trackAbbr = {
DATA_SCIENCE: 'DS',
@@ -280,7 +280,7 @@ export function getReviewOpportunitiesFilterFunction(state, validTypes) {
filterByTrack(challenge, state)
&& filterByText(challenge, state)
&& filterByTags(challenge, state)
// && filterByTypes(challenge, state)
&& filterByTypes(challenge, state)
&& filterByEndDate(challenge, state)
&& filterByStartDate(challenge, state)
&& filterByReviewOpportunityType(opp, state)