-
Notifications
You must be signed in to change notification settings - Fork 52
add clearProfile action and reducer for clear all profile info #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add clearProfile action and reducer for clear all profile info #21
Conversation
add clearProfile action annd reducer for clear all profile info for fix topcoder-platform/community-app#1192
src/actions/profile.js
Outdated
@@ -415,6 +423,7 @@ function updatePasswordDone(profile, tokenV3, newPassword, oldPassword) { | |||
export default createActions({ | |||
PROFILE: { | |||
LOAD_PROFILE: loadProfile, | |||
CLEAR_PROFILE: clearProfile, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we just use Lodash's noop
instead of an empty method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me try
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ThomasKranitsas you mean _.noop ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah noop work, updated the code, pls check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clearProfile -> _.noop
add clearProfile action annd reducer for clear all profile info
for fix topcoder-platform/community-app#1192