Skip to content

Revert Notifications Analytics and Config change #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 13, 2020
6 changes: 0 additions & 6 deletions __tests__/__snapshots__/index.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -387,11 +387,5 @@ Object {
"delay": [Function],
"formatDuration": [Function],
},
"tracking": Object {
"default": undefined,
"event": [Function],
"init": [Function],
"pageView": [Function],
},
}
`;
3 changes: 1 addition & 2 deletions config/default.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,5 @@
"AV_SCAN_SCORER_REVIEW_TYPE_ID": "",
"PROVISIONAL_SCORING_COMPLETED_REVIEW_TYPE_ID": "",
"PAGE_SIZE": 50,
"REVIEW_OPPORTUNITY_PAGE_SIZE": 1000,
"GOOGLE_ANALYTICS_ID": ""
"REVIEW_OPPORTUNITY_PAGE_SIZE": 1000
}
3 changes: 1 addition & 2 deletions config/development.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"AV_SCAN_SCORER_REVIEW_TYPE_ID": "68c5a381-c8ab-48af-92a7-7a869a4ee6c3",
"PROVISIONAL_SCORING_COMPLETED_REVIEW_TYPE_ID": "52c91e85-745f-4e62-b592-9879a2dfe9fd",
"GOOGLE_ANALYTICS_ID": "UA-161803421-1"
"PROVISIONAL_SCORING_COMPLETED_REVIEW_TYPE_ID": "52c91e85-745f-4e62-b592-9879a2dfe9fd"
}
3 changes: 1 addition & 2 deletions config/production.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"AV_SCAN_SCORER_REVIEW_TYPE_ID": "55bbb17d-aac2-45a6-89c3-a8d102863d05",
"PROVISIONAL_SCORING_COMPLETED_REVIEW_TYPE_ID": "df51ca7d-fb0a-4147-9569-992fcf5aae48",
"GOOGLE_ANALYTICS_ID": "UA-6340959-1"
"PROVISIONAL_SCORING_COMPLETED_REVIEW_TYPE_ID": "df51ca7d-fb0a-4147-9569-992fcf5aae48"
}
1 change: 0 additions & 1 deletion config/webpack/default.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ module.exports = {
'moment-duration-format',
'react',
'react-dom',
'react-ga',
'redux',
'redux-actions',
'isomorphic-fetch',
Expand Down
7 changes: 3 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,16 @@
},
"scripts": {
"build": "npm run clean && npm run build:dev && npm run build:prod",
"build:dev": "./node_modules/.bin/webpack --env=development --progress --profile --colors --display-optimization-bailout",
"build:dev": "NODE_ENV=development ./node_modules/.bin/webpack --env=development --progress --profile --colors --display-optimization-bailout",
"build:dev:watch": "npm run clean && ./node_modules/.bin/webpack --env=development --progress --profile --colors --watch --display-optimization-bailout",
"build:prod": "./node_modules/.bin/webpack --env=production --progress --profile --colors --display-optimization-bailout",
"build:prod": "NODE_ENV=production ./node_modules/.bin/webpack --env=production --progress --profile --colors --display-optimization-bailout",
"clean": "rimraf dist",
"jest": "jest --no-cache --maxWorkers=4 --config config/jest/default.js",
"lint": "npm run lint:js",
"lint:js": "./node_modules/.bin/eslint --ext .js,.jsx .",
"test": "npm run lint && npm run jest"
},
"version": "0.17.0",
"version": "0.17.2",
"dependencies": {
"auth0-js": "^6.8.4",
"config": "^3.2.0",
Expand All @@ -44,7 +44,6 @@
"qs": "^6.5.2",
"react": "^16.4.1",
"react-dom": "^16.4.1",
"react-ga": "^2.7.0",
"react-redux": "^6.0.1",
"redux": "^3.7.2",
"redux-actions": "^2.4.0",
Expand Down
2 changes: 1 addition & 1 deletion src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ export { actions } from './actions';
export { services } from './services';

export {
challenge, logger, errors, tc, time, mock, submission, tracking,
challenge, logger, errors, tc, time, mock, submission,
} from './utils';
2 changes: 0 additions & 2 deletions src/utils/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import * as mock from './mock';
import * as errors from './errors';
import * as filter from './challenge/filter';
import * as submission from './submission';
import * as tracking from './tracking';

const challenge = {
filter,
Expand All @@ -22,5 +21,4 @@ export {
mock,
errors,
submission,
tracking,
};
47 changes: 0 additions & 47 deletions src/utils/tracking.js

This file was deleted.