fix(PM-855): allow pm to access all applications #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -21,23 +21,17 @@ module.exports = freq => new Promise((resolve, reject) => { | |||
| const req = freq; | |||
| req.context = req.context || {}; | |||
| req.context.currentOpportunity = opportunity; | |||
| const projectId = opportunity.projectId; | |||
| const isProjectManager = util.hasProjectManagerRole(req); | |||
There was a problem hiding this comment.
The variable projectId is declared but never used in the modified code. Consider removing it to clean up the code.
| }, | ||
| }).then((copilotApplication) => { | ||
| // check if auth user has access to this project | ||
| const hasAccess = util.hasAdminRole(req) || isProjectManager || !!copilotApplication; |
There was a problem hiding this comment.
The logic for determining hasAccess has changed. Previously, it checked if the user was part of the project members, but now it only checks if the user is a project manager. Ensure this change aligns with the intended functionality described in the pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What' in this PR?
Ticket link - https://topcoder.atlassian.net/browse/PM-855