use submission api v5 to download submission #90
Conversation
deedee
force-pushed
the
download-use-submission-api
branch
7 times, most recently
from
7ddfcf7 to
994d0c0
Compare
deedee
force-pushed
the
download-use-submission-api
branch
from
994d0c0 to
a9322fe
Compare
|
@deedee Was this closed intentionally? Is there an alternative PR? |
|
@callmekatootie I thought this task was cancel. Do you want me to reopen this? |
|
@deedee Checking... they asked me to review this but I see now that its closed 😄 Will let you know |
|
Hey @deedee - there's been a misunderstanding. This task is very much active. Could you kindly reopen this and let me know if it is ready to be reviewed? |
|
@callmekatootie Yes it's ready for review |
src/java/main/com/cronos/onlinereview/actions/projectdetails/BaseProjectDetailsAction.java
Outdated
Show resolved
Hide resolved
src/java/main/com/cronos/onlinereview/actions/projectdetails/BaseProjectDetailsAction.java
Outdated
Show resolved
Hide resolved
src/java/main/com/cronos/onlinereview/actions/projectdetails/BaseProjectDetailsAction.java
Outdated
Show resolved
Hide resolved
|
@callmekatootie change done on new commit. |
|
@skyhit Are the updates fine? |
| } | ||
|
|
||
| } catch(Exception e) { | ||
| throw new BaseException(e.getMessage()); |
There was a problem hiding this comment.
@deedee should include the root cause.
|
|
||
| servletResponse.flushBuffer(); | ||
|
|
||
| OutputStream out = null; |
There was a problem hiding this comment.
@deedee this is some logic to pipe input stream to output stream, I think it is better code it as a separate method for clearness.
| servletResponse.setHeader("Content-Type", response.getEntity().getContentType().getValue()); | ||
| servletResponse.setStatus(HttpServletResponse.SC_OK); | ||
| servletResponse.setIntHeader("Content-Length", (int) response.getEntity().getContentLength()); | ||
| servletResponse.setHeader("Content-Disposition", response.getHeaders("Content-Disposition")[0].getValue()); |
There was a problem hiding this comment.
@deedee what if there is no Content-Disposition, then there will be index out of boundary issue.
|
@deedee sorry, foget to submit some new comments, please check again |
|
@callmekatootie @skyhit new change has been pushed |
|
@deedee @callmekatootie from code review, looks good to me. |
|
Ticket #89 |
|
Current Status:
|
new token property
@submission_api_endpoint@=http://localhost:3000/api/v5