Reskin or only

.circleci/config.yml

@@ -190,7 +190,8 @@ workflows:
           filters: 
             branches:
               only:
-                - dev-maven
+                - reskin-or
+                - ci-fix-test
 
       - deployProd:
           context : org-global

src/main/java/com/cronos/onlinereview/actions/projectdetails/BaseProjectDetailsAction.java

@@ -181,6 +181,76 @@ protected CorrectnessCheckResult checkForCorrectUploadId(HttpServletRequest requ
         return result;
     }
 
+    /**
+     * This method verifies the request for certain conditions to be met. This includes verifying
+     * if the user has specified an ID of project he wants to perform an operation on, if the
+     * ID of the project specified by user denotes an existing project, and whether the user
+     * has enough rights to perform the operation specified by <code>permission</code> parameter.
+     *
+     * @return an instance of the {@link CorrectnessCheckResult} class, which specifies whether the
+     *         check was successful and, in the case the check was successful, contains additional
+     *         information retrieved during the check operation, which might be of some use for the
+     *         calling method.
+     * @param request
+     *            the http request.
+     * @param permission
+     *            permission to check against, or <code>null</code> if no check is required.
+     * @throws BaseException
+     *             if any error occurs.
+     */
+    protected CorrectnessCheckResult checkForCorrectProjectId(HttpServletRequest request,
+                                                            String permission) throws BaseException {
+        // Prepare bean that will be returned as the result
+        CorrectnessCheckResult result = new CorrectnessCheckResult();
+
+        if (permission == null || permission.trim().length() == 0) {
+            permission = null;
+        }
+
+        // Verify that Project ID was specified and denotes correct project
+        String pidParam = request.getParameter("pid");
+        if (pidParam == null || pidParam.trim().length() == 0) {
+            result.setResult(ActionsHelper.produceErrorReport(
+                    this, request, permission, "Error.ProjectIdNotSpecified", null));
+            // Return the result of the check
+            return result;
+        }
+
+        long pid;
+
+        try {
+            // Try to convert specified pid parameter to its integer representation
+            pid = Long.parseLong(pidParam, 10);
+        } catch (NumberFormatException e) {
+            result.setResult(ActionsHelper.produceErrorReport(
+                    this, request, permission, "Error.ProjectNotFound", null));
+            // Return the result of the check
+            return result;
+        }
+
+        // Retrieve the project following submission's information chain
+        Project project = ActionsHelper.createProjectManager().getProject(pid);
+        if (project == null) {
+            result.setResult(ActionsHelper.produceErrorReport(
+                    this, request, permission, "Error.ProjectNotFound", null));
+            // Return the result of the check
+            return result;
+        }
+
+        request.setAttribute("pid", pid);
+
+        // Store Project object in the result bean
+        result.setProject(project);
+        // Place project as attribute in the request
+        request.setAttribute("project", project);
+
+        // Gather the roles the user has for current request
+        AuthorizationHelper.gatherUserRoles(request, project.getId());
+
+        // Return the result of the check
+        return result;
+    }
+
     /**
      * <p>
      * Sends the content of specified file for downloading by client.

src/main/java/com/cronos/onlinereview/actions/projectdetails/DownloadFinalFixAction.java

@@ -54,10 +54,16 @@ public String execute() throws BaseException, IOException {
         LoggingHelper.logAction(request);
 
         // Verify that certain requirements are met before processing with the Action
-        CorrectnessCheckResult verification = checkForCorrectUploadId(request, Constants.DOWNLOAD_FINAL_FIX_PERM_NAME);
+        CorrectnessCheckResult verification_pid = checkForCorrectProjectId(request, Constants.DOWNLOAD_FINAL_FIX_PERM_NAME);
         // If any error has occurred, return action forward contained in the result bean
-        if (!verification.isSuccessful()) {
-            return verification.getResult();
+        if (!verification_pid.isSuccessful()) {
+            return verification_pid.getResult();
+        }
+
+        CorrectnessCheckResult verification_uid = checkForCorrectUploadId(request, Constants.DOWNLOAD_FINAL_FIX_PERM_NAME);
+        // If any error has occurred, return action forward contained in the result bean
+        if (!verification_uid.isSuccessful()) {
+            return verification_uid.getResult();
         }
 
         boolean hasPermission = false, hasSubmitterRole = false;
@@ -94,7 +100,7 @@ public String execute() throws BaseException, IOException {
         }
 
         // Get the upload the user wants to download
-        Upload upload = verification.getUpload();
+        Upload upload = verification_uid.getUpload();
 
         if (!hasPermission) {
             ActionsHelper.logDownloadAttempt(request, upload, false);

src/main/java/com/cronos/onlinereview/actions/projectlinks/EditProjectLinksAction.java

@@ -5,9 +5,11 @@
 
 import com.cronos.onlinereview.Constants;
 import com.cronos.onlinereview.actions.DynamicModelDrivenAction;
+import com.cronos.onlinereview.util.AuthorizationHelper;
 import com.cronos.onlinereview.model.DynamicModel;
 import com.cronos.onlinereview.util.ActionsHelper;
 import com.cronos.onlinereview.util.Comparators;
+import com.cronos.onlinereview.util.ConfigHelper;
 import com.cronos.onlinereview.util.CorrectnessCheckResult;
 import com.cronos.onlinereview.util.LoggingHelper;
 import com.topcoder.onlinereview.component.exception.BaseException;
@@ -69,6 +71,25 @@ public String execute() throws BaseException {
         }
 
         Project project = verification.getProject();
+        request.setAttribute("projectStatus", project.getProjectStatus().getName());
+
+        final String projectTypeName = project.getProjectCategory().getProjectType().getName();
+
+        boolean hasForumType = project.getAllProperties().containsKey("Forum Type");
+
+        long projectId = project.getId();
+        long forumId = -1;
+        String tempStr;
+
+        tempStr = (String) project.getProperty("Developer Forum ID");
+        if (tempStr != null && tempStr.trim().length() != 0) {
+            forumId = Long.parseLong(tempStr, 10);
+        }
+
+        request.setAttribute("viewContestLink", ConfigHelper.getProjectTypeViewContestLink(projectTypeName, projectId));
+
+        request.setAttribute("forumLink", ConfigHelper.getProjectTypeForumLink(
+                (projectTypeName.equalsIgnoreCase("studio") && hasForumType) ? "NewStudio" : projectTypeName, forumId));
 
         // obtains the project link manager
         ProjectLinkManager linkManager = ActionsHelper.createProjectLinkManager();
@@ -92,6 +113,8 @@ public String execute() throws BaseException {
 
         // set up projects except for deleted ones
         request.setAttribute("allProjects", allProjects);
+        request.setAttribute("isAllowedToContactPM",
+        AuthorizationHelper.hasUserPermission(request, Constants.CONTACT_PM_PERM_NAME));
 
         // Populate the form with project and project link properties
         populateProjectLinkForm(getModel(), verification.getProject());

src/main/java/com/cronos/onlinereview/actions/projectmanagementconsole/ViewManagementConsoleAction.java

@@ -9,6 +9,7 @@
 import com.cronos.onlinereview.util.AuthorizationHelper;
 import com.cronos.onlinereview.util.CorrectnessCheckResult;
 import com.cronos.onlinereview.util.LoggingHelper;
+import com.cronos.onlinereview.util.ConfigHelper;
 import com.topcoder.onlinereview.component.project.management.Project;
 import com.topcoder.onlinereview.component.exception.BaseException;
 
@@ -64,6 +65,28 @@ public String execute() throws BaseException {
             Project project = verification.getProject();
             initProjectManagementConsole(request, project);
 
+            request.setAttribute("projectStatus", project.getProjectStatus().getName());
+
+            final String projectTypeName = project.getProjectCategory().getProjectType().getName();
+
+            boolean hasForumType = project.getAllProperties().containsKey("Forum Type");
+
+            long projectId = project.getId();
+            long forumId = -1;
+            String tempStr;
+
+            tempStr = (String) project.getProperty("Developer Forum ID");
+            if (tempStr != null && tempStr.trim().length() != 0) {
+                forumId = Long.parseLong(tempStr, 10);
+            }
+
+            request.setAttribute("viewContestLink", ConfigHelper.getProjectTypeViewContestLink(projectTypeName, projectId));
+
+            request.setAttribute("forumLink", ConfigHelper.getProjectTypeForumLink(
+                (projectTypeName.equalsIgnoreCase("studio") && hasForumType) ? "NewStudio" : projectTypeName, forumId));
+            request.setAttribute("isAllowedToContactPM",
+                AuthorizationHelper.hasUserPermission(request, Constants.CONTACT_PM_PERM_NAME));
+
             return Constants.SUCCESS_FORWARD_NAME;
         }
     }

src/main/java/com/cronos/onlinereview/actions/projectpayments/EditProjectPaymentsAction.java

@@ -8,8 +8,10 @@
 import com.cronos.onlinereview.Constants;
 import com.cronos.onlinereview.util.ActionsHelper;
 import com.cronos.onlinereview.util.AuthorizationHelper;
+import com.cronos.onlinereview.util.ConfigHelper;
 import com.cronos.onlinereview.util.CorrectnessCheckResult;
 import com.cronos.onlinereview.util.LoggingHelper;
+import com.topcoder.onlinereview.component.project.management.Project;
 import com.topcoder.onlinereview.component.project.payment.ProjectPayment;
 import com.topcoder.onlinereview.component.project.payment.ProjectPaymentManager;
 import com.topcoder.onlinereview.component.project.payment.ProjectPaymentFilterBuilder;
@@ -64,7 +66,30 @@ public String execute() throws BaseException {
         // At this point, redirect-after-login attribute should be removed (if it exists)
         AuthorizationHelper.removeLoginRedirect(request);
 
-        long projectId = verification.getProject().getId();
+        Project project = verification.getProject();
+
+        request.setAttribute("projectStatus", project.getProjectStatus().getName());
+
+        final String projectTypeName = project.getProjectCategory().getProjectType().getName();
+
+        boolean hasForumType = project.getAllProperties().containsKey("Forum Type");
+
+        long projectId = project.getId();
+        long forumId = -1;
+        String tempStr;
+
+        tempStr = (String) project.getProperty("Developer Forum ID");
+        if (tempStr != null && tempStr.trim().length() != 0) {
+            forumId = Long.parseLong(tempStr, 10);
+        }
+
+        request.setAttribute("viewContestLink", ConfigHelper.getProjectTypeViewContestLink(projectTypeName, projectId));
+
+        request.setAttribute("forumLink", ConfigHelper.getProjectTypeForumLink(
+                (projectTypeName.equalsIgnoreCase("studio") && hasForumType) ? "NewStudio" : projectTypeName, forumId));
+        request.setAttribute("isAllowedToContactPM",
+                AuthorizationHelper.hasUserPermission(request, Constants.CONTACT_PM_PERM_NAME));
+
         ProjectPaymentManager projectPaymentManager = ActionsHelper.createProjectPaymentManager();
         List<ProjectPayment> payments = projectPaymentManager.search(
                 ProjectPaymentFilterBuilder.createProjectIdFilter(projectId));

src/main/java/com/cronos/onlinereview/actions/projectpayments/ViewProjectPaymentsAction.java

@@ -13,6 +13,7 @@
 import com.cronos.onlinereview.util.ConfigHelper;
 import com.cronos.onlinereview.util.CorrectnessCheckResult;
 import com.cronos.onlinereview.util.LoggingHelper;
+import com.topcoder.onlinereview.component.project.management.Project;
 import com.topcoder.onlinereview.component.project.payment.ProjectPayment;
 import com.topcoder.onlinereview.component.project.payment.ProjectPaymentManager;
 import com.topcoder.onlinereview.component.project.payment.ProjectPaymentFilterBuilder;
@@ -65,7 +66,27 @@ public String execute() throws BaseException {
         // At this point, redirect-after-login attribute should be removed (if it exists)
         AuthorizationHelper.removeLoginRedirect(request);
 
-        long projectId = verification.getProject().getId();
+        Project project = verification.getProject();
+
+        request.setAttribute("projectStatus", project.getProjectStatus().getName());
+
+        final String projectTypeName = project.getProjectCategory().getProjectType().getName();
+
+        boolean hasForumType = project.getAllProperties().containsKey("Forum Type");
+
+        long projectId = project.getId();
+        long forumId = -1;
+        String tempStr;
+
+        tempStr = (String) project.getProperty("Developer Forum ID");
+        if (tempStr != null && tempStr.trim().length() != 0) {
+            forumId = Long.parseLong(tempStr, 10);
+        }
+
+        request.setAttribute("viewContestLink", ConfigHelper.getProjectTypeViewContestLink(projectTypeName, projectId));
+
+        request.setAttribute("forumLink", ConfigHelper.getProjectTypeForumLink(
+                (projectTypeName.equalsIgnoreCase("studio") && hasForumType) ? "NewStudio" : projectTypeName, forumId));
         ProjectPaymentManager projectPaymentManager = ActionsHelper.createProjectPaymentManager();
         List<ProjectPayment> payments = projectPaymentManager.search(
                 ProjectPaymentFilterBuilder.createProjectIdFilter(projectId));
@@ -74,6 +95,8 @@ public String execute() throws BaseException {
         Resource[] resources = ActionsHelper.getAllResourcesForProject(verification.getProject());
         populateResourcesMap(request, resources);
         request.setAttribute("payments", payments);
+        request.setAttribute("isAllowedToContactPM",
+                AuthorizationHelper.hasUserPermission(request, Constants.CONTACT_PM_PERM_NAME));
         request.setAttribute("isAllowedToEditPayments",
                 AuthorizationHelper.hasUserPermission(request, Constants.EDIT_PAYMENTS_PERM_NAME));
         request.setAttribute("pactsPaymentDetailBaseURL", ConfigHelper.getPactsPaymentDetailBaseURL());

src/main/java/com/cronos/onlinereview/mockups/MockHandleTag.java

@@ -185,8 +185,9 @@ public int doEndTag() throws JspException {
             textColor = "coderTextOrange";
         }
 
+
         // Start preparing resulting output
-        StringBuilder results = new StringBuilder("<a href=\"http://www.topcoder.com/tc?module=MemberProfile&cr=");
+        StringBuilder results = new StringBuilder("<a href=\"http://<%=ApplicationServer.SERVER_NAME%>/tc?module=MemberProfile&cr=");
         // appending coder's id to the generated link
         results.append(coderId);
         // tab will be specified only if tab local variable is not empty

src/main/java/com/cronos/onlinereview/util/AuthorizationHelper.java

@@ -219,6 +219,9 @@ public static void gatherUserRoles(HttpServletRequest request) throws BaseExcept
             ExternalUser extUser = usrMgr.retrieveUser(getLoggedInUserId(request));
             // Place handle of the user into session as attribute
             request.getSession().setAttribute("userHandle", extUser.getHandle());
+            request.getSession().setAttribute("userFirstName", extUser.getFirstName());
+            request.getSession().setAttribute("userLastName", extUser.getLastName());
+            request.getSession().setAttribute("userEmail", extUser.getEmail());
         }
 
         // Perform search for resources
@@ -478,7 +481,7 @@ private static AuthorizationService retrieveAuthorizationService(HttpServletRequ
      * Sets the sso cookie service to be used for authenticating users based on
      * cookie.
      * </p>
-     * 
+     *
      * @param ssoCookieService the ssoCookieService to set
      */
     public void setSsoCookieService(SSOCookieService ssoCookieService) {
@@ -489,7 +492,7 @@ public void setSsoCookieService(SSOCookieService ssoCookieService) {
      * <p>
      * Validate jwt token
      * </p>
-     * 
+     *
      * @param token the jwt token
      * @throws JWTException if any error occurs
      * @return the DecodedJWT result

src/main/java/com/cronos/onlinereview/util/ConfigHelper.java

@@ -593,6 +593,11 @@ public class ConfigHelper {
      */
     private static final String CHALLENGE_BY_LEGACY_ID_URL_V5 = "challenge_by_legacy_id_url_v5";
 
+    /**
+     * <p>A <code>String</code> providing support requests v5 url property.</p>
+     */
+    private static final String SUPPORT_REQUEST_URL_V5 = "support_request_url_v5";
+
     /**
      * This member variable holds the submitter role id.
      */
@@ -1069,6 +1074,11 @@ public class ConfigHelper {
      */
     private static String challengeByLegacyIdUrlV5;
 
+    /**
+     * Support Request URL
+     */
+    private static String supportRequestUrlV5;
+
     static {
         // Obtaining the instance of Configuration Manager
         ConfigManager cfgMgr = new ConfigManager();
@@ -1696,6 +1706,8 @@ public class ConfigHelper {
             newAuthUrl = newAuth.getValue("new_auth_url");
 
             challengeByLegacyIdUrlV5 = cfgMgr.getString(ONLINE_REVIEW_CFG_NS, CHALLENGE_BY_LEGACY_ID_URL_V5);
+
+            supportRequestUrlV5 = cfgMgr.getString(ONLINE_REVIEW_CFG_NS, SUPPORT_REQUEST_URL_V5);
         } catch (Exception une) {
             System.out.println(une.getMessage());
             une.printStackTrace();
@@ -2586,4 +2598,12 @@ public static String getNewAuthUrl() {
     public static String getChallengeByLegacyIdUrlV5() {
         return challengeByLegacyIdUrlV5;
     }
+
+    /**
+     * Get support request url
+     * @return url
+     */
+    public static String getSupportRequestUrlV5() {
+        return supportRequestUrlV5;
+    }
 }