Skip to content

Master maven #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 22, 2022
3 changes: 3 additions & 0 deletions src/main/java/com/cronos/onlinereview/model/PhaseGroup.java
Original file line number Diff line number Diff line change
Expand Up @@ -1376,6 +1376,9 @@ public Submission getIterativeReviewSubmission() {
* @param iterativeReviewSubmission a <code>Submission</code> providing the details on iterative review submission.
*/
public void setIterativeReviewSubmission(Submission iterativeReviewSubmission) {
if (iterativeReviewSubmission == null) {
return;
}
this.iterativeReviewSubmission = iterativeReviewSubmission;
Upload upload = iterativeReviewSubmission.getUpload();
this.iterativeReadyToDownload = upload == null || upload.getUrl() == null || !ActionsHelper.isDmzBucket(upload.getUrl());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1139,22 +1139,24 @@ private static void serviceIterativeReviewsAppFunc(HttpServletRequest request, P
throw new BaseException("Unable to find the Submitter resource "
+ "associated with the current user for project " + project.getId());
}

Submission[] mySubmissions = ActionsHelper.getResourceSubmissions(myResource.getId(),
Constants.CONTEST_SUBMISSION_TYPE_NAME, null, false);
if (mySubmissions != null) {
for (Submission submission : mySubmissions) {
if (submission.getId() == associatedSubmission.getId()) {
phaseGroup.setIterativeReviewSubmission(associatedSubmission);
if (associatedSubmission != null) {
Submission[] mySubmissions = ActionsHelper.getResourceSubmissions(myResource.getId(),
Constants.CONTEST_SUBMISSION_TYPE_NAME, null, false);
if (mySubmissions != null) {
for (Submission submission : mySubmissions) {
if (submission.getId() == associatedSubmission.getId()) {
phaseGroup.setIterativeReviewSubmission(associatedSubmission);
}
}
}
}
}

for (Resource resource : allProjectResources) {
if (resource.getId() == associatedSubmission.getUpload().getOwner()) {
phaseGroup.setIterativeReviewSubmitter(resource);
break;
if (associatedSubmission != null) {
for (Resource resource : allProjectResources) {
if (resource.getId() == associatedSubmission.getUpload().getOwner()) {
phaseGroup.setIterativeReviewSubmitter(resource);
break;
}
}
}

Expand Down