Supporting release for Connect 2.4.7 #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikasrohit
commented
Nov 2, 2018
vikasrohit
commented
- Multi service deployment to avoid silent killing of the kafka consumers
- Email template update for missing events
- Handled few more kafka topics to generate connect notifications
- Now we don't send emails to inactive users
— Fixed, not sending emails now for inactive users. Ideally, we should not have generated the notification for inactive users, however, that requires querying all target users details when generating notifications and we are not doing that right now. So differing that change for now and instead putting a safe guard for sending emails. It would be helpful in cases where user is made inactive between notification generation and actual email sending.
issue #72 - connect.action.timeline.adjusted is not handled
…more fault tolerant
…tances per task while deploying
…eployment Multi service deployment to avoid silent failures of kafka consumers
… working for Outlook users — Fixed. Removed table inside anchor tag. Instead achieved centre aligned text of the button using paddings.
m2m token through auth0-proxy server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.