Skip to content

Community Notifications Changes #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 19, 2020
Merged

Community Notifications Changes #183

merged 13 commits into from
Mar 19, 2020

Conversation

sachin-maheshwari
Copy link
Contributor

@sachin-maheshwari sachin-maheshwari commented Mar 16, 2020 •
edited
Loading

Covers following issue/features -

  • member api rate limit issue
  • Duplicate notifications
  • Stopping "A new submission is uploaded" events (submission.notification.create)
  • Changes as per described at Checkpoint Review Notification community-app#4114
  • Public group logic changes - now excluding group like ["!CS", "!Zurich", "!Topgear"]

@SathyaJayabal
Copy link

verified on dev
Stopping "A new submission is uploaded" events (submission.notification.create)

Tracked here : topcoder-platform/community-app#4108

@SathyaJayabal
Copy link

verified on dev
Duplicate notifications
tracked here:topcoder-platform/community-app#4105

@SathyaJayabal
Copy link

Verified on dev
member api rate limit issue
tracked here:#182

@SathyaJayabal
Copy link

SathyaJayabal commented Mar 18, 2020 •
edited
Loading

Public group logic changes - now excluding group like ["!CS", "!Zurich", "!Topgear"]
tracked here : topcoder-platform/community-app#4121

When the groups filter is empty, then all users should receive the notification. But users belonging to any group. (eg:cognitive) do not receive the notification.

updated topcoder-platform/community-app#4121 with comments

@SathyaJayabal
Copy link

verified on dev
Changes as per described at topcoder-platform/community-app#4114

@SathyaJayabal
Copy link

@sachin-maheshwari
Public group logic changes - now excluding group like ["!CS", "!Zurich", "!Topgear"]
tracked here : topcoder-platform/community-app#4121

verified on dev

@sachin-maheshwari
Copy link
Contributor Author

@SathyaJayabal thank you! 👍

@sachin-maheshwari sachin-maheshwari merged commit 899da23 into dev Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sachin-maheshwari @SathyaJayabal