[Hotfix] [Dev] fix duplicates in emails

[maxceem]

Fix for the issue which is tracked in Connect App appirio-tech/connect-app#3216

Additionally, make a fix for a potential issue. See commit message for details.

[vikasrohit]

LGTM. @maxceem I don't think we should ever miss the initatorUserId in the even payload and if it is happening somewhere, we might need to debug it. However, on the other hand, there might be a case where the event is not triggered by a user but it is system event, in which case we might not have the initiator user id. But still, we can supply a system user id in such cases to uniquely identify the initiator.
However, I don't think the safety check would harm us any way. So, we should be good for now.

[vikasrohit]

Just to confirm @maxceem we are not merging this hotfix to master, right?

[maxceem]

Just to confirm @maxceem we are not merging this hotfix to master, right?

I was thinking that we would like to merge it to master as a hotfix. Looks like I've accidentally created it agains the dev.

[vikasrohit]

Okay, if we have the front end changes for it in our next hotfix for 2.4.15.2, we can create hotfix against master for this repo as well. No issue with that as well.

[maxceem]

Okay, if we have the front end changes for it in our next hotfix for 2.4.15.2, we can create hotfix against master for this repo as well. No issue with that as well.

This issue only requires changes in the tc-notifications repo in this PR. No frontend changes are required. So it can be merged now as a hotfix, or it can be wait until the next release of the tc-notificatons repo if this issue is not urgent.

[vikasrohit]

Okay. Lets create hotfix for it against master as well. We would merge it with Connect 2.4.15.2

[maxceem]

Here is PR against master #158