New user roles #152
Merged
New user roles #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New user roles with "manager" level project roles have the same configuration as existent users with project "manager" role. ref appirio-tech/connect-app#3298
|
@maxceem I think we can add tc-notifications/connect/events-config.js Line 68 in 3d8b02e tc-notifications/connect/events-config.js Line 61 in 3d8b02e draft status altogether.
|
Users with Topcoder role 'Business Development Representative' get the same notifications as users with Topcoder Role 'Connect Account Manager' ref appirio-tech/connect-app#3298
|
Nice catch @vikasrohit I've missed this role. PR is updated for both cases to keep the current code consistent. |
vikasrohit
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support of new user roles as per appirio-tech/connect-app#3298
New user roles with "manager" level project roles have the same configuration as existent users with project "manager" role.
I've tested this locally, works good. I can see new notifications created for the user with new role in the DB.