Skip to content

updated image link to point to connect-app static resources #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

akumar1503
Copy link
Contributor

For this issue on connect app.

updated image link to point to connect-app static resorces in email templates.

@maxceem
Copy link
Contributor

maxceem commented May 16, 2019

@vikasrohit this PR looks good to me.

I think it can be merged.

To apply changes we should do 2 things:

  1. Deploy cf17 which contains this PR which implement serving static files inside Connect App.
  2. Update all the templates from this repository inside the Sendgrid.

@vikasrohit
Copy link

Thanks @maxceem. We will merge the cf17 as per our schedule i.e. after closing the challenge. What exactly we need to change in templates? We only have one template and you can do that changes here.

@maxceem
Copy link
Contributor

maxceem commented May 16, 2019

@vikasrohit yes, the changes are already done in this PR we are commented to. You can have a look on the changed files https://github.com/topcoder-platform/tc-notifications/pull/116/files

@vikasrohit
Copy link

Thanks for pointer., I thought I am commenting on connect-app issue 😬. Will merge this PR when we merge the cf17 in connect-app.

@vikasrohit vikasrohit merged commit 891d4b8 into topcoder-platform:dev Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants