PM-1142 - reset tax forms #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
prisma/migrations/20250425134520_truncate_tax_forms/migration.sql
Outdated
Show resolved
Hide resolved
prisma/migrations/20250425134520_truncate_tax_forms/migration.sql
Outdated
Show resolved
Hide resolved
| @@ -1,13 +1,9 @@ | |||
| import { TaxFormStatus } from './adminWinning.dto'; | |||
|
|
|||
| export class TaxFormQueryResult { | |||
| id: string; | |||
There was a problem hiding this comment.
Consider adding type annotations for the properties in the TaxFormQueryResult class to ensure type safety and clarity. For example, id: string; could be id: string;.
There was a problem hiding this comment.
@kkartunov lol. this one is funny:
For example, id: string; could be id: string;
kkartunov
requested changes
Apr 29, 2025
prisma/migrations/20250425134520_truncate_tax_forms/migration.sql
Outdated
Show resolved
Hide resolved
prisma/migrations/20250425134520_truncate_tax_forms/migration.sql
Outdated
Show resolved
Hide resolved
kkartunov
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/PM-1142
Migration file to:
docusign_envelopestable & related enumsuser_tax_form_associationstable with columns: user_id, tax_form_id, date_filed, tax_form_status.tax_formstax_form_statusto reflect status from trolleyUpdated services & controller to get rid of handling "net_amount" based on filled-in tax forms.