Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PM-1100 - endpoint for fetching trolley portal url #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PM-1100 - endpoint for fetching trolley portal url #29
Changes from 1 commit
7c485b9
47baaaf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
ResponseDto
type seems to be imported fromadminWinning.dto
, which might not be the most appropriate place for a DTO related to payment providers. Consider creating a new DTO file or moving it to a more relevant location.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using a more specific error type instead of a generic
Error
to provide better error handling and debugging.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
findFirst
method might returnnull
if no record is found. Ensure that subsequent operations handle this case appropriately.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding error handling for the
update
method to manage potential update failures.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding error handling for the
findUnique
method to manage cases where the recipient cannot be retrieved.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding error handling for the
getPayeeRecipient
method to manage cases where the recipient cannot be retrieved or created.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
request.email
property is being used here, but it is not clear from the context ifrequest.email
is a valid property of therequest
object. Ensure thatrequest.email
is correctly set and available before this line to avoid potential runtime errors.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Including
PaymentProvidersModule
andWebhooksModule
in the Swagger document might not be necessary for the/trolley/portal-link
endpoint unless these modules are directly related to the endpoint's functionality. Please ensure that these modules are required for the new endpoint and remove them if they are not relevant.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in environment variable name:
TORLLEY_ACCESS_KEY
should beTROLLEY_ACCESS_KEY
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vas3a please check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in environment variable name:
TORLLEY_SECRET_KEY
should beTROLLEY_SECRET_KEY
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in environment variable usage:
TORLLEY_ACCESS_KEY
should beTROLLEY_ACCESS_KEY
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vas3a please check