Configure Cloudfront/S3 Caching Behavior #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooketopcoder
changed the title
brooketopcoder
changed the title
testflyjets
approved these changes
Dec 6, 2022
… condition Added fix to invalidate cache, if cloundfront it provided without any condition
Gunasekar-K
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the cache behavior as follows, which is how I would expect it work given the naming conventions.
If the app enables caching:
ENABLE_CACHE = true/CFACHE = trueSet the max age in the cache-control for the files in S3 to
--cache-control max-age=0,s-maxage=86400, which will allow CloudFront to cache them.Invalidate the CloudFront distribution.
If the app disables caching:
ENABLE_CACHE = false/CFCACHE = falseSet the max age in the cache-control for the files in S3 to
--cache-control private,no-store,no-cache,must-revalidate,max-age=0, which will prevent CloudFront from ever caching it.Do not invalidate the CloudFront distribution because the cache-control on the files renders cache invalidation irrelevant.