Skip to content

Removes \n that were being output literally #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions master_deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ configure_docker_private_login() {

# ECS Deployment Functions
ECS_push_ecr_image() {
echo "\n\n"
echo ""
if [ -z "$APP_IMAGE_NAME" ];
then
log "ECS image follows the standard format"
Expand Down Expand Up @@ -160,7 +160,7 @@ ECS_push_ecr_image() {
eval $(aws ecr get-login --region $AWS_REGION --no-include-email)
docker push $AWS_ACCOUNT_ID.dkr.ecr.$AWS_REGION.amazonaws.com/$AWS_REPOSITORY:$ECS_TAG
track_error $? "ECS ECR image push"
log "Docker Image published\n\n"
log "Docker Image published"
}

ECSCLI_push_ecr_image() {
Expand All @@ -178,7 +178,7 @@ ECSCLI_push_ecr_image() {
eval $(aws ecr get-login --region $AWS_REGION --no-include-email)
docker push $AWS_ACCOUNT_ID.dkr.ecr.$AWS_REGION.amazonaws.com/$ECS_REPONAME:$ECS_TAG
track_error $? "ECS ECR image push"
log "Docker ECR Image published\n\n"
log "Docker ECR Image published"
}

ECSCLI_update_env()
Expand Down Expand Up @@ -520,7 +520,8 @@ ECS_deploy_cluster() {
return 1
fi

echo "Updated service intialised successfully for deployment\n\n"
echo "Updated service intialised successfully for deployment"
echo
fi

return 0
Expand Down Expand Up @@ -553,17 +554,18 @@ validate_update_loggroup()
#echo $log_group_fetch
if [ -z $log_group_fetch ];
then
echo "\nLog group does not exist\n"
echo "Log group does not exist"
aws logs create-log-group --log-group-name /aws/ecs/$AWS_ECS_CLUSTER
track_error $? "aws log group"
else
echo "\nLog group exists\n"
echo "Log group exists"
fi
echo
}

# EBS integration
ebsportmapping() {
echo "Port map called\n"
echo "Port map called"
containerport=$1
hostport=$2

Expand Down