Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

The Rates show value 10 by default instead of 0 #103

Closed
sdgun opened this issue Aug 10, 2021 · 11 comments
Closed

The Rates show value 10 by default instead of 0 #103

sdgun opened this issue Aug 10, 2021 · 11 comments

Comments

@sdgun
Copy link
Collaborator

sdgun commented Aug 10, 2021

Steps
Go to TAAS Admin >> Roles
Click create new role button
Click Add rate and check the default rates

By default 10 is set on all rates instead of 0

2021-08-10_13-38-42.mp4
@cagdas001
Copy link
Contributor

@sdgun 0 is not a valid value anymore because fields accept only positive integers

@nikolay83
Copy link

I don't think it's P2 (rather P4) as we would hardly have rates equal or lower than $10/week :) Rather starting from $1000/week.

@sdgun
Copy link
Collaborator Author

sdgun commented Aug 10, 2021

Hi @nikolay83 @cagdas001 No issue in reducing the priority considering that. But I am wondering since only the Global rate is a mandatory field here the user will have to manually delete all other fields in case if the user doesn't want to set Rate 30/Rate 20 etc. Will it not be useful to keep them empty rather if this is a valid use case?

@cagdas001
Copy link
Contributor

Then maybe we should auto-populate only the mandatory fields and should leave blank other fields

@cagdas001
Copy link
Contributor

One of the reasons I auto populate them is actually to indicate it's a number field. Because it currently looks like a regular text field (after removing +/- buttons), user may try to input letters instead of numbers. Inputting letters will not result in any error message to let user know about this, what they will see is just a non-working field because what they enter wont be reflected in the field (non numeric chars are not allowed to type)

So we should either indicate in some way (like auto populating some default values) that it's a number field, or allow non-numeric chars as well to be able to type (with error messages on invalid inputs)

I think populating only the default fields also should work to indicate they're numbers...

That's my 2 cents...

@nikolay83
Copy link

@wdprice
do you want to set the minimum weekly rate in Admin Roles UI?

@cagdas001
Copy link
Contributor

do you want to set the minimum weekly rate in Admin Roles UI?

Just following on the discussion. Did you mean "default" values, as discussed above? Or you're talking about another thing and "minimum" is the correct term?

@nikolay83
Copy link

I think the default can be a minimum. Anyway, rates as low as $10/week don't make sense and if displayed to a customer may be even more confusing than "N/A".

@nikolay83
Copy link

Requirement: just auto-populate all the rates with $1000.

@sdgun
Copy link
Collaborator Author

sdgun commented Aug 14, 2021

Verified in Dev, fixed.

2021-08-14_11-04-44.mp4

@sdgun
Copy link
Collaborator Author

sdgun commented Aug 16, 2021

Verified in production.

image

image

@sdgun sdgun closed this as completed Aug 16, 2021
@SathyaJayabal SathyaJayabal transferred this issue from topcoder-archive/topcoder-platform-taas-app Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants