Implemented Nylas calendar connect & delete functionalities. #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added method to create real Zoom meeting links.
Now, Zoom account credentials are loaded from only one env variable and then parsed in the Zoom service for use. Also changed the tracking method for available Zoom credentials left to use. Its still in-memory.
Removed custom error handling logic previously implemented in the controller. Now its handled by the default error handler in app.js file & the error is invoked from the service. Updated the 'handleConnectCalendarCallback' method in the service to stop creating duplicate calendars. And when connecting a new calendar and making it primary, the method makes the other existing calendars in the UserMeetingSettings record non-primary. Additionally, updated the 'deleteUserCalendar' method in the service to give better error messages and to make another existing calendar as primary when deleting a primary calendar. Also, this method now envokes errors and lets the default error handler instead of the controller to handle them.
maxceem
suggested changes
Oct 20, 2021
There was a problem hiding this comment.
Hi @mahidulalvi-bonic, sorry for the delay with review, had some issues during reviewing.
I cannot test the changes fully, because when I connect Microsoft calendar for user who doesn't have UserMeetingSettings records yet, it's not created. So I cannot test deletion and duplication issues.
See the log when I connect Microsoft account https://monosnap.com/file/LDj8fXfmIJlhOKvsBkmIcoI3fRbfJX
There are no errors, but no records were added to the UserMeetingSettings table: https://monosnap.com/file/KkGMK74kqu3TrkWWFuyZEXtgUSFOiL
maxceem
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added method to create real Zoom meeting links.