fix #337 #341
Merged
fix #337 #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxceem
reviewed
Jun 12, 2021
src/services/WorkPeriodService.js
Outdated
Comment on lines
522
to
523
| const workPeriods = await WorkPeriod.findAndCountAll(queryCriteria) | ||
| const total = await WorkPeriod.count({ where: filter }) |
There was a problem hiding this comment.
@xxcxy I didn't know such a method exists. I wonder why you didn't use the output from this method and call await WorkPeriod.count({ where: filter }) anyway below?
Can we just call findAndCountAll?
There was a problem hiding this comment.
Strange, I forgot to change this. I tried findAndCountAll, the count returned by this method is wrong.
There was a problem hiding this comment.
Thanks @eisbilir. I think than it’s better not use it, because if we use it one place then new developer can copy paste it to a new place with include and would not notice that it works incorrectly there.
maxceem
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verifications screens:
Job:
es: https://monosnap.com/file/uQc48PsX3meBTsSPmHe5USLV7vUj0L
db: https://monosnap.com/file/9t2sVwk60IuiGE3JJoLAOFkr4O963s
jobCandidate:
es: https://monosnap.com/file/fc56yIJM0OpYb8p8VVGPoSVTp2eqFp
db: https://monosnap.com/file/b0QoqZGJ00KnIGjrnmKWwrG9QtqUk9
interview:
es: https://monosnap.com/file/JEsbEZwYb03eCf23sVTVpmyvgqEPin
db: https://monosnap.com/file/MiDPNcvnqo2CBFp0TPzOTo2h3jAF0a
workPeroid:
es: https://monosnap.com/file/cy3Myc0iMIbU9mBlT0o0R3PPhPCdjp
db: https://monosnap.com/file/Egb5p4YLAOfN2FlJSOf1hALqiEnOH8
wrokPeroidPayment:
es: https://monosnap.com/file/wv6JAYKmuzKPUCI05jIPEUYV5Z8KYs
db: https://monosnap.com/file/8q5vopLwh26yhwQfTDJ0yQonbvIylA