Skip to content

[$75] Missing fields of connected calendars #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maxceem opened this issue Oct 21, 2021 · 5 comments
Open

[$75] Missing fields of connected calendars #590

maxceem opened this issue Oct 21, 2021 · 5 comments

Comments

@maxceem
Copy link
Contributor

maxceem commented Oct 21, 2021

Branch: feature/interview-update

There are various cases when after adding or deleting calendars, some calendars are missing in the UserMeetingSettings record. Expected behaviour: each calendar should always have the next 5 fields:

  • id <- calendar id
  • accountId
  • accountProvider
  • accessToken
  • isPrimary

Failed Cases

    • User doesn't have UserMeetingSettings
    • We add Microsoft calenadr
    • There is not primary calendar from Nylas returned, so we use any writable calendar

    Missing fields:id and isPrimary flag, see screenshot

    • User has UserMeetingSettings with one Microsoft calendar from above without id and isPrimary
    • We add Google calendar
    • Microsoft calendar disappears and there is no id for google calendar, see screenshot
    • If after this we again connect Microsoft Calendar, then Google Calendar disappears, and there is no id, see screenshot

I guess most of these issues are because of the missing id.

Task

Verify all these cases and make sure that we always have all 5 fields in all calendar records:

  1. User doesn't have UserMeetingSettings. Connect calendar which doesn't have is_primary at Nylas.
  2. User doesn't have UserMeetingSettings. Connect calendar which has is_primary at Nylas.
  3. User has UserMeetingSettings. Connect calendar which doesn't have is_primary at Nylas.
  4. User has UserMeetingSettings. Connect calendar which has is_primary at Nylas.
  5. Remove not last primary calendar, so another one become primary.
  6. Remove last primary calendar, so no calendars left.
  7. Any other case worth testing?
@maxceem maxceem changed the title Missing fields of connected calendars [$75] Missing fields of connected calendars Oct 21, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Oct 21, 2021

Assigned to @mahidulalvi-bonic

@maxceem
Copy link
Contributor Author

maxceem commented Oct 24, 2021

@maxceem maxceem added the PAID Paid manually without TCX label Oct 24, 2021
@sandhiyakavi
Copy link
Collaborator

@maxceem I am currently able to view only 4 fields and accessToken field is missing and accountId field is displayed as email

image

@maxceem
Copy link
Contributor Author

maxceem commented Nov 1, 2021

@sandhiyakavi that's an expected behaviour. I think we can treat this issue as internal technical issue, if scheduling/calendar connection work well, it means that we get all the necessary fields.

accountId and accessToken should never be returned by API to the client as per challenge-2, because they give access to user calendars, and we only use them internally.

email is the new field we added recently to show in UI when calendar is connected as per topcoder-archive/topcoder-platform-taas-app#531

@sdgun
Copy link
Collaborator

sdgun commented Apr 4, 2022

Unable to verify this in production since we haven't released connect calender feature to production yet.

@sdgun sdgun removed this from the Interview Update (Nylas) milestone Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants