Skip to content

[$60]Update unit tests dependency #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
veshu opened this issue Oct 28, 2020 · 4 comments
Closed

[$60]Update unit tests dependency #3

veshu opened this issue Oct 28, 2020 · 4 comments
Assignees
@dengzikun
Labels
tcx_Assigned tcx_FixAccepted tcx_Paid tcx_ReadyForReview
Milestone
v1.0 - Initial La...

Comments

@veshu
Copy link
Contributor

veshu commented Oct 28, 2020

Currently it requires database and es to run the unit tests. Such dependencies should be mocked.
@veshu veshu changed the title Update unit tests dependency [$60]Update unit tests dependency Oct 28, 2020
@veshu veshu added bug Something isn't working tcx_OpenForPickup labels Oct 28, 2020
@veshu
Copy link
Contributor Author

veshu commented Oct 28, 2020

Contest https://www.topcoder.com/challenges/30147466 has been created for this ticket.

This is an automated message for veshu via Topcoder X

@veshu
Copy link
Contributor Author

veshu commented Oct 28, 2020

Contest https://www.topcoder.com/challenges/30147466 has been updated - it has been assigned to zxyding.

This is an automated message for veshu via Topcoder X

@veshu veshu added tcx_Assigned and removed tcx_OpenForPickup bug Something isn't working labels Oct 28, 2020
@veshu
Copy link
Contributor Author

veshu commented Oct 30, 2020 •
edited
Loading

@dengzikun got the following errors if I don't configure m2m token and for unit tests it should not require to be actual token. Please mock this API call.

image

@veshu veshu closed this as completed Nov 3, 2020
@veshu
Copy link
Contributor Author

veshu commented Nov 3, 2020

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30147466

This is an automated message for veshu via Topcoder X

@veshu veshu added the tcx_Paid label Nov 3, 2020
imcaizheng added a commit to imcaizheng/taas-apis that referenced this issue Feb 9, 2021
@imcaizheng
Remove endDate from Job and add duration to Job
e2e1084 
- Updated model definition
- Updated Joi schemas
- Updated Swagger
- Added migration script
- Fixed existing lint errors
- Updated Postman collection

The following requests in Postman is updated:

* Jobs
    * create job with booking manager
    * create job with m2m create
    * create job with connect user
    * create job with member success
    * create job with user id not exist
    * create job with invalid token
    * put job with booking manager
    * put job with m2m update
    * put job with connect user
    * put job with member 403
    * put job with member success
    * put job with member with user id not exist
    * put job with invalid token
    * patch job with booking manager
    * patch job with m2m update
    * patch job with connect user
    * patch job with member 403
    * patch job with member success
    * patch job with user id not exist
    * patch job with invalid token
* Create Demo Data For Team
  * Create job topcoder-platform#1 "sourcing"
      * create job topcoder-platform#1
  * Create job topcoder-platform#2 "in-review"
      * create job topcoder-platform#2
  * Create job topcoder-platform#3 "assigned"
      * create job topcoder-platform#3
  * Create job topcoder-platform#4 "closed"
      * create job topcoder-platform#4
  * Create job topcoder-platform#5 "cancelled"
      * create job topcoder-platform#5
* Test Permission Rules
  * Request with Administrator Role
    * Jobs
        * ✔ create job with administrator
        * ✔ put job with administrator
        * ✔ patch job with administrator
  * Request with Topcoder User Role
    * Jobs
        * ✔ create job with member
        * ✔ put job with member
        * ✔ patch job with member
  * Request with Connect Manager Role
    * Jobs
        * ✔ create job with connect manager
        * ✔ put job with connect manager
        * ✔ patch job with connect manager
@imcaizheng imcaizheng mentioned this issue Feb 9, 2021
Merged
@maxceem maxceem added this to the v1.0 - Initial Launch milestone Feb 24, 2021
deblasis added a commit to deblasis/taas-apis that referenced this issue Oct 8, 2021
@deblasis
Makefile
00cd86c 
Fixes topcoder-platform#4
Fixes topcoder-platform#3
Fixes topcoder-platform#2
Fixes topcoder-platform#1

Signed-off-by: Alessandro De Blasis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dengzikun dengzikun

Labels
tcx_Assigned tcx_FixAccepted tcx_Paid tcx_ReadyForReview
Projects
None yet
Milestone
v1.0 - Initial Launch
Development

No branches or pull requests
3 participants
@maxceem @veshu @dengzikun