fix: issue topcoder-archive/topcoder-platform-taas-app#570

Author: yoution

config/default.js

@@ -306,7 +306,7 @@ module.exports = {
   // frequency of checking expired interview
   CRON_INTERVIEW_EXPIRED: process.env.CRON_INTERVIEW_EXPIRED || '*/5 * * * *',
   // frequency of checking interview schedule status which need remind job candidate to select time
-  CRON_INTERVIEW_SCHEDULE_REMINDER: process.env.CRON_INTERVIEW_SCHEDULE_REMINDER || '00 00 13 * * 0-6',
+  CRON_INTERVIEW_SCHEDULE_REMINDER: process.env.CRON_INTERVIEW_SCHEDULE_REMINDER || '*/5 * * * *',
   // frequency of cron checking for post interview actions
   CRON_POST_INTERVIEW: process.env.CRON_POST_INTERVIEW || '00 00 13 * * 0-6',
   // frequency of cron checking for upcoming resource bookings
@@ -315,6 +315,8 @@ module.exports = {
   INTERVIEW_COMING_UP_MATCH_WINDOW: process.env.INTERVIEW_COMING_UP_MATCH_WINDOW || 'PT5M',
   // The remind time for fetching interviews which are coming up
   INTERVIEW_COMING_UP_REMIND_TIME: (process.env.INTERVIEW_COMING_UP_REMIND_TIME || 'PT1H,PT24H').split(','),
+  // The match window for fetching schedule reminder interviews
+  INTERVIEW_SCHEDULE_REMINDER_WINDOW: process.env.INTERVIEW_SCHEDULE_REMINDER_WINDOW || 'PT5M',
   // The match window for fetching completed interviews
   INTERVIEW_COMPLETED_MATCH_WINDOW: process.env.INTERVIEW_COMPLETED_MATCH_WINDOW || 'PT5M',
   // The interview completed past time for fetching interviews

src/services/NotificationsSchedulerService.js

@@ -596,7 +596,7 @@ async function sendInterviewScheduleReminderNotifications () {
 
   localLogger.debug('[sendInterviewScheduleReminderNotifications]: Looking for due records...')
   const currentTime = moment.utc()
-  const compareTime = currentTime.add(-INTERVIEW_REMINDER_DAY_AFTER).add(1, 'days').startOf('day')
+  const compareTime = currentTime.clone().subtract(moment.duration(INTERVIEW_REMINDER_DAY_AFTER)).endOf('day')
 
   const timestampFilter = {
     [Op.and]: [
@@ -631,25 +631,28 @@ async function sendInterviewScheduleReminderNotifications () {
   let interviewCount = 0
   for (const interview of interviews) {
     const start = moment(interview.createdAt)
-    if (currentTime.subtract(INTERVIEW_REMINDER_DAY_AFTER).diff(start, 'days') % INTERVIEW_REMINDER_FREQUENCY === 0) {
-      // sendEmail
-      const data = await getDataForInterview(interview)
-      if (!data) { continue }
-
-      if (!_.isEmpty(data.guestEmail)) {
-        // send guest emails
-        sendNotification({}, {
-          template,
-          recipients: [{ email: data.guestEmail }],
-          data: {
-            ...data,
-            subject: `Reminder: ${data.duration} minutes tech interview with ${data.guestFullName} for ${data.jobTitle} is requested by the Customer`
-          }
-        })
-      } else {
-        localLogger.error(`Interview id: ${interview.id} guest emails not present`, 'sendInterviewScheduleReminderNotifications')
+    if (currentTime.clone().subtract(INTERVIEW_REMINDER_DAY_AFTER).diff(start, 'days') % INTERVIEW_REMINDER_FREQUENCY === 0) {
+      const minutesInterval = currentTime.clone().diff(start, 'minutes') % (60 * 24)
+      if (minutesInterval < moment.duration(config.INTERVIEW_SCHEDULE_REMINDER_WINDOW).minutes()) {
+        // sendEmail
+        const data = await getDataForInterview(interview)
+        if (!data) { continue }
+
+        if (!_.isEmpty(data.guestEmail)) {
+          // send guest emails
+          sendNotification({}, {
+            template,
+            recipients: [{ email: data.guestEmail }],
+            data: {
+              ...data,
+              subject: `Reminder: ${data.duration} minutes tech interview with ${data.guestFullName} for ${data.jobTitle} is requested by the Customer`
+            }
+          })
+        } else {
+          localLogger.error(`Interview id: ${interview.id} guest emails not present`, 'sendInterviewScheduleReminderNotifications')
+        }
+        interviewCount++
       }
-      interviewCount++
     }
   }