[$100] Issues with interview schedule reminder notification

[sdgun]

Observed the below issues in in interview schedule reminder notification:

Issue 1

All reminder emails related to different interviews were sent at the same time irrespective of their start time, is there a scheduled time to send this or is it ssent after like 1 hour of the selected start time?

time.mp4

Issue 2

'minutes' text is missing

[maxceem]

Sum up:

• Issue 2 would be fixed in Sendgrid.
• Only issue 1 is in scope
• This happens because the logic we use is not correct.
  • sendInterviewScheduleReminderNotifications is triggered each day the same time. so all notification are send at the same time.
  • instead of it these notification has to be sent 24 hours after interview. createdAt
• Solution:
  • update logic, to be similar like we send interview coming up notification sendInterviewComingUpNotifications
  • update cron timing CRON_INTERVIEW_SCHEDULE_REMINDER to '*/5 * * * *' - so it run every 5 minutes
  • and check if there any interviews with createdAt from now (including now) till 5 minutes later (not including)
  • and send notification for such interviews
• Update demo script https://github.com/topcoder-platform/taas-apis/blob/dev/scripts/demo-email-notifications/index.js to tigger such notification for demo. DON"T break other demo examples in this script.
• Update Postman Notification Demo so we can trigger this notification from Postman https://monosnap.com/file/3yifghvTy4mk5D0L8C1216W4dn4Cbl (don't break other).

[maxceem]

@yoution this is also ready to pick up.

[yoution]

@maxceem pleaae assign to me

[maxceem]

@yoution it appears that this issue is blocked by another one topcoder-platform/taas-apis#618.

Please, hold on working on this issue until the other one is fixed, we are working on that.

[maxceem]

@yoution you may keep working on this issue, as blocking issue topcoder-platform/taas-apis#618 has been fixed.

[yoution]

@maxceem you said we should seach the interviews by startTimestampt,
but the status of current interview is scheduling, I think we should search by createdAt , please confirm?

[maxceem]

@yoution you are right we have to use createdAt - updated task description.

[yoution]

@maxceem can we don't work on these two tasks

• Update demo script: we should update the createdAt to currentTime, but it seems we can't modify this field,https://github.com/topcoder-platform/taas-apis/blob/dev/scripts/demo-email-notifications/index.js#L72 , is it readonly?
• Update Postman: I think create interview is enough

[maxceem]

ok @yoution, no need

[maxceem]

Hey, @yoution I've checked your PR, I think my task was not clear.

• We still have to send reminders only after 1 day (INTERVIEW_REMINDER_DAY_AFTER) after the interview was created. So if the user was invited but didn't reply - we send a reminder.
• After INTERVIEW_REMINDER_DAY_AFTER we have to send this reminder every day (configured by INTERVIEW_REMINDER_FREQUENCY)

Previously it was implemented like this, but it sent reminders at the same time for all people. But we have to count time from createdAt for each individual interview.

I would update the payment for this task to $100, would you be willing to update it accordingly?

[sdgun]

The issues are fixed.

[maxceem]

Challenge https://www.topcoder.com/challenges/cd80fe0a-4073-42bd-8e24-7257d82ffd4a has been created for this ticket.

This is an automated message for maxceem via Topcoder X

[maxceem]

Challenge https://www.topcoder.com/challenges/cd80fe0a-4073-42bd-8e24-7257d82ffd4a has been assigned to yoution.

This is an automated message for maxceem via Topcoder X

[maxceem]

Payment task has been updated: https://www.topcoder.com/challenges/cd80fe0a-4073-42bd-8e24-7257d82ffd4a
Payments Complete
Winner: yoution
Copilot: maxceem
Challenge cd80fe0a-4073-42bd-8e24-7257d82ffd4a has been paid and closed.

This is an automated message for maxceem via Topcoder X