fix: issue topcoder-archive/topcoder-platform-taas-app#570

Author: yoution

config/default.js

@@ -306,7 +306,7 @@ module.exports = {
   // frequency of checking expired interview
   CRON_INTERVIEW_EXPIRED: process.env.CRON_INTERVIEW_EXPIRED || '*/5 * * * *',
   // frequency of checking interview schedule status which need remind job candidate to select time
-  CRON_INTERVIEW_SCHEDULE_REMINDER: process.env.CRON_INTERVIEW_SCHEDULE_REMINDER || '00 00 13 * * 0-6',
+  CRON_INTERVIEW_SCHEDULE_REMINDER: process.env.CRON_INTERVIEW_SCHEDULE_REMINDER || '*/5 * * * *',
   // frequency of cron checking for post interview actions
   CRON_POST_INTERVIEW: process.env.CRON_POST_INTERVIEW || '00 00 13 * * 0-6',
   // frequency of cron checking for upcoming resource bookings
@@ -319,10 +319,8 @@ module.exports = {
   INTERVIEW_COMPLETED_MATCH_WINDOW: process.env.INTERVIEW_COMPLETED_MATCH_WINDOW || 'PT5M',
   // The interview completed past time for fetching interviews
   INTERVIEW_COMPLETED_PAST_TIME: process.env.INTERVIEW_COMPLETED_PAST_TIME || 'PT4H',
-  // Reminder after days if Job Candidate hasn't selected time
-  INTERVIEW_REMINDER_DAY_AFTER: process.env.INTERVIEW_REMINDER_DAY_AFTER || 'P1D',
-  // Reminder frequency if Job Candidate hasn't selected time, unit: day
-  INTERVIEW_REMINDER_FREQUENCY: parseInt(process.env.INTERVIEW_REMINDER_FREQUENCY) || 1,
+  // The match window for fetching scheduling interviews
+  INTERVIEW_REMINDER_MATCH_WINDOW: process.env.INTERVIEW_REMINDER_MATCH_WINDOW || 'PT5M',
   // How far in the feature we may allow scheduling interview, unit: day
   INTERVIEW_AVAILABLE_DAYS_IN_FEATURE: parseInt(process.env.INTERVIEW_AVAILABLE_DAYS_IN_FEATURE) || 15,
   // The time before resource booking expiry when we should start sending notifications

scripts/demo-email-notifications/index.js

@@ -69,7 +69,7 @@ async function resetNotificationRecords () {
 
   const interviewForReminder = await Interview.findById('a23e1bf2-1084-4cfe-a0d8-d83bc6fec655')
   // update hostUserId to test user phash_manager
-  await interviewForReminder.update({ createdAt: moment().subtract(moment.duration(config.INTERVIEW_REMINDER_DAY_AFTER)).toDate(), hostUserId: '57646ff9-1cd3-4d3c-88ba-eb09a395366c' })
+  await interviewForReminder.update({ createdAt: moment().toDate(), hostUserId: '57646ff9-1cd3-4d3c-88ba-eb09a395366c' })
 
   const interviewExpired = await Interview.findById('505db942-79fe-4b6f-974c-b359e1b61967')
   await interviewExpired.update({ expireTimestamp: moment().subtract(moment.duration(1, 'days')).toDate(), hostUserId: '57646ff9-1cd3-4d3c-88ba-eb09a395366c' })

src/services/NotificationsSchedulerService.js

@@ -591,17 +591,20 @@ async function sendNotification (currentUser, data, webNotifications = []) {
 
 // Send notifications to job candicate for time selection reminder
 async function sendInterviewScheduleReminderNotifications () {
-  const INTERVIEW_REMINDER_DAY_AFTER = config.get('INTERVIEW_REMINDER_DAY_AFTER')
-  const INTERVIEW_REMINDER_FREQUENCY = config.get('INTERVIEW_REMINDER_FREQUENCY')
-
   localLogger.debug('[sendInterviewScheduleReminderNotifications]: Looking for due records...')
-  const currentTime = moment.utc()
-  const compareTime = currentTime.add(-INTERVIEW_REMINDER_DAY_AFTER).add(1, 'days').startOf('day')
+
+  const window = moment.duration(config.INTERVIEW_REMINDER_MATCH_WINDOW)
+  const currentTime = moment.utc().startOf('minute')
+  const rangeStart = currentTime.clone().subtract(window)
+  const rangeEnd = currentTime.clone()
 
   const timestampFilter = {
     [Op.and]: [
       {
-        [Op.lte]: compareTime
+        [Op.gte]: rangeStart
+      },
+      {
+        [Op.lt]: rangeEnd
       }
     ]
   }
@@ -630,27 +633,24 @@ async function sendInterviewScheduleReminderNotifications () {
 
   let interviewCount = 0
   for (const interview of interviews) {
-    const start = moment(interview.createdAt)
-    if (currentTime.subtract(INTERVIEW_REMINDER_DAY_AFTER).diff(start, 'days') % INTERVIEW_REMINDER_FREQUENCY === 0) {
-      // sendEmail
-      const data = await getDataForInterview(interview)
-      if (!data) { continue }
-
-      if (!_.isEmpty(data.guestEmail)) {
-        // send guest emails
-        sendNotification({}, {
-          template,
-          recipients: [{ email: data.guestEmail }],
-          data: {
-            ...data,
-            subject: `Reminder: ${data.duration} minutes tech interview with ${data.guestFullName} for ${data.jobTitle} is requested by the Customer`
-          }
-        })
-      } else {
-        localLogger.error(`Interview id: ${interview.id} guest emails not present`, 'sendInterviewScheduleReminderNotifications')
-      }
-      interviewCount++
+    // sendEmail
+    const data = await getDataForInterview(interview)
+    if (!data) { continue }
+
+    if (!_.isEmpty(data.guestEmail)) {
+      // send guest emails
+      sendNotification({}, {
+        template,
+        recipients: [{ email: data.guestEmail }],
+        data: {
+          ...data,
+          subject: `Reminder: ${data.duration} minutes tech interview with ${data.guestFullName} for ${data.jobTitle} is requested by the Customer`
+        }
+      })
+    } else {
+      localLogger.error(`Interview id: ${interview.id} guest emails not present`, 'sendInterviewScheduleReminderNotifications')
     }
+    interviewCount++
   }
 
   localLogger.debug(`[sendInterviewScheduleReminderNotifications]: Sent notifications for ${interviewCount} interviews which need to schedule.`)