Skip to content

Need sortBy param for submissions endpoint #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sushilshinde opened this issue Aug 5, 2019 · 6 comments
Closed

Need sortBy param for submissions endpoint #124

sushilshinde opened this issue Aug 5, 2019 · 6 comments

Comments

@sushilshinde
Copy link
Contributor

sushilshinde commented Aug 5, 2019

Endpoint: /submissions

Need sortBy param for this endpoint, initially, it should support sort by rankings

For more inclusive design it should use : sortBy=key1:asc,key2:desc,key3:asc value pattern

@sushilshinde sushilshinde changed the title Need sortBy param for submission endpoint Need sortBy param for submissions endpoint Aug 5, 2019
@callmekatootie
Copy link
Contributor

We need to watch out for

if (actResource === 'submission') {
and consider it in our change

@callmekatootie
Copy link
Contributor

@sushilshinde

initially, it should support sort by rankings

Could you elaborate here - which attribute on the submission are you expecting the sorting to happen?

@callmekatootie
Copy link
Contributor

@sharathkumaranbu Discussed with Sushil. We need to provide a generic sort parameter, one of which is the sorting based on the review summation score for a submission

@callmekatootie
Copy link
Contributor

callmekatootie added a commit that referenced this issue Aug 18, 2019
2. Provide sortyBy parameter when querying #124
3. Change which attribute is used to name artifacts in submissions #125
@callmekatootie
Copy link
Contributor

callmekatootie commented Aug 18, 2019

PR Ready: #127

@callmekatootie
Copy link
Contributor

PR merged. Closing ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants