fix: for issue 51, add support sorting by 'GET /resources' endpoint #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootelement
reviewed
Dec 19, 2020
| @@ -31,7 +31,11 @@ const initES = async () => { | |||
| const body = { mappings: {} } | |||
| body.mappings[config.get('ES.ES_TYPE')] = { | |||
| properties: { | |||
| id: { type: 'keyword' } | |||
| id: { type: 'keyword' }, | |||
| memberHandle: { | |||
There was a problem hiding this comment.
Does this change mean we have to do anything to the existing Dynamo DB? I don't see any change to the model. Just making sure
There was a problem hiding this comment.
We don't need to change any thing with Dynamo DB, because search is making in Elasticsearch.
| @@ -33,7 +33,7 @@ module.exports = { | |||
| // AWS_SECRET_ACCESS_KEY: process.env.AWS_FAKE_KEY, | |||
| AWS_REGION: process.env.AWS_REGION || 'us-east-1', | |||
| IS_LOCAL_DB: process.env.IS_LOCAL_DB ? process.env.IS_LOCAL_DB === 'true' : true, | |||
| URL: process.env.DYNAMODB_URL || 'http://localhost:8000', | |||
| DYNAMODB_URL: process.env.DYNAMODB_URL || 'http://localhost:8000', | |||
There was a problem hiding this comment.
Not sure what this change is for. Did you change all the uses of this value throughout the app?
There was a problem hiding this comment.
In all places it tries to get Dynamo DB url using "DYNAMODB.DYNAMODB_URL" path and I need to change only this file.
rootelement
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.